Remove lastnames feature from MlCitation payload #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
** Why are these changes being introduced: * We are removing the lastnames feature from the MlCitation detector. It will still be extracted by Detector::Citation, but the algorithm within the detector won't support it. ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/tco-155 ** How does this address that need: This filters out the lastnames feature from Detector::MlCitation's extract_features method, which prevents it from being sent to the lambda. The cassettes are also regenerated. Two of them are just removed, which confuses me as they should still be needed. ** Document any side effects to this change: None, as far as I know
jazairi
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer
Why are these changes being introduced:
How does this address that need:
This filters out the lastnames feature from Detector::MlCitation's extract_features method, which prevents it from being sent to the lambda.
The cassettes are also regenerated. Two of them are just removed, which confuses me as they should still be needed.
Document any side effects to this change:
None, as far as I know
Summary of changes (please refer to commit messages for full details)
Ticket(s)
https://mitlibraries.atlassian.net/browse/TCO-155
Accessibility
all issues introduced by these changes have been resolved or opened
as new issues (link to those issues in the Pull Request details above)
Documentation
ENV
Stakeholders
Dependencies and migrations
NO dependencies are updated
NO migrations are included
Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing