From 9f627a4bee3e4fca92f55835f311397ab93610eb Mon Sep 17 00:00:00 2001
From: jazairi <16103405+jazairi@users.noreply.github.com>
Date: Tue, 3 Dec 2024 16:13:54 -0500
Subject: [PATCH] Remove ProQuest submission field from thesis forms

Why these changes are being introduced:

The Libraries are suspending the pilot with ProQuest, and the
thesis forms should be updated.

Relevant ticket(s):

* [ETD-658](https://mitlibraries.atlassian.net/browse/ETD-658)

How this addresses that need:

This removes the ProQuest fieldset from the new and edit forms.
It also removes the author_fields partial, which includes only this
fieldset.

Note that this does not remove any additional ProQuest export
functionality, as specifically requested by stakeholders.

Side effects of this change:

Because no functionality outside of the thesis form has been
changed, thesis processors can still run ProQuest exports. There
is no apparent risk to this, and we can fully remove the feature
if stakeholders decide to do so.
---
 app/views/thesis/_author_fields.html.erb | 13 -------------
 app/views/thesis/edit.html.erb           | 13 -------------
 app/views/thesis/new.html.erb            | 13 -------------
 3 files changed, 39 deletions(-)
 delete mode 100644 app/views/thesis/_author_fields.html.erb

diff --git a/app/views/thesis/_author_fields.html.erb b/app/views/thesis/_author_fields.html.erb
deleted file mode 100644
index 298f96da..00000000
--- a/app/views/thesis/_author_fields.html.erb
+++ /dev/null
@@ -1,13 +0,0 @@
-<h4>Consent to send thesis to ProQuest</h4>
-<div class="proquest">
-  <p>We are conducting a pilot program to provide additional open access to MIT theses through <a href='http://libguides.mit.edu/dissertations'>ProQuest Dissertation & Theses Global</a> (PQDT). The aim is to make theses more visible and discoverable.</p>
-  <p>There is no cost to you and your thesis will not be sent to ProQuest until it is published by MIT. See <a href='https://about.proquest.com/en/dissertations/proquest-dissertations-frequently-asked-questions/proquest-dissertations-authors-frequently-asked-questions/'>PQDT's Author Dissertations FAQs</a> for more information about participating.</p>
-  <fieldset>
-    <legend>ProQuest consent *</legend>
-    <%= f.input :proquest_allowed, as: :radio_buttons,
-                                   collection: [['Yes', true], ['No', false]],
-                                   required: true,
-                                   validate_presence: true,
-                                   label: "I would like the full-text of my thesis to be made openly available in ProQuest Dissertation & Theses Global.".html_safe %>
-  </fieldset>
-</div>
diff --git a/app/views/thesis/edit.html.erb b/app/views/thesis/edit.html.erb
index 430c30a6..e69ee040 100644
--- a/app/views/thesis/edit.html.erb
+++ b/app/views/thesis/edit.html.erb
@@ -183,12 +183,6 @@
                                 hint: 'If anything is incorrect in the non-editable fields, tell us here.'.html_safe,
                                 hint_html: { id: 'thesis_author_note-hint', class: 'col3q' } %>
 
-      <%= f.simple_fields_for :authors do |author| %>
-        <% if author.object.user_id == current_user.id && satisfies_advanced_degree?(@thesis) %>
-          <%= render 'author_fields', f: author %>
-        <% end %>
-      <% end %>
-
       <div class='field-row'>
         <%= submit_tag 'Submit thesis information', class: 'btn button-primary' %>
       </div>
@@ -205,13 +199,6 @@
 
 <script type="text/javascript">
   $("form.thesisSubmission").validate({
-    errorPlacement: function(error, element) {
-      if (element.attr("name") == "thesis[authors_attributes][0][proquest_allowed]") {
-        error.insertBefore(element);
-      } else {
-        error.insertAfter(element);
-      }
-    },
     invalidHandler: function(event, validator) {
       var errors = validator.numberOfInvalids();
       if (errors) {
diff --git a/app/views/thesis/new.html.erb b/app/views/thesis/new.html.erb
index 48bc0124..e91eba50 100644
--- a/app/views/thesis/new.html.erb
+++ b/app/views/thesis/new.html.erb
@@ -181,12 +181,6 @@
                               hint: 'If anything is incorrect in the non-editable fields, tell us here.'.html_safe,
                               hint_html: { id: 'thesis_author_note-hint', class: 'col3q' } %>
 
-    <%= f.simple_fields_for :authors do |author| %>
-      <% if author.object.user_id == current_user.id %>
-        <%= render 'author_fields', f: author %>
-      <% end %>
-    <% end %>
-
     <div class='field-row'>
       <%= submit_tag 'Submit thesis information', class: 'btn button-primary' %>
     </div>
@@ -200,13 +194,6 @@
 
 <script type="text/javascript">
   $("#new_thesis").validate({
-    errorPlacement: function(error, element) {
-      if (element.attr("name") == "thesis[authors_attributes][0][proquest_allowed]") {
-        error.insertBefore(element);
-      } else {
-        error.insertAfter(element);
-      }
-    },
     invalidHandler: function(event, validator) {
       var errors = validator.numberOfInvalids();
       if (errors) {