From c7f05d4bda1485d30930c1add3120ce95c31307e Mon Sep 17 00:00:00 2001
From: jazairi <16103405+jazairi@users.noreply.github.com>
Date: Fri, 29 Mar 2024 11:53:36 -0400
Subject: [PATCH] Update access type values

Why these changes are being introduced:

The "access to files" values have been changed in the data mapping
layer. We need to make a corresponding change in a few partials
where the value of that field is a rendering condition.

Relevant ticket(s):

* [GDT-252](https://mitlibraries.atlassian.net/browse/GDT-252)

How this addresses that need:

This updates the values as needed in the access_button, record_geo, and
geo_data_info partials, as well as the access_type helper method.

Side effects of this change:

It was a bit tricky to wrangle and update all of these hardcoded values.
Though they are unlikely to change again, this is something that
we may want to consider refactoring.
---
 app/helpers/record_helper.rb             |  2 +-
 app/views/record/_access_button.html.erb |  4 ++--
 app/views/record/_record_geo.html.erb    |  2 +-
 app/views/shared/_geo_data_info.html.erb |  6 +++---
 test/helpers/record_helper_test.rb       | 12 ++++++------
 5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/app/helpers/record_helper.rb b/app/helpers/record_helper.rb
index bfa632fe..36c45d99 100644
--- a/app/helpers/record_helper.rb
+++ b/app/helpers/record_helper.rb
@@ -83,7 +83,7 @@ def gis_access_link(metadata)
 
     # At this point, we don't show download links for non-MIT records. For MIT records, the download link is stored
     # consistently as a download link. We are confirming that the link text is 'Data' for added confirmation.
-    if access_type(metadata) == 'Not owned by MIT'
+    if access_type(metadata) == 'unknown: check with owning institution'
       links.select { |link| link['kind'] == 'Website' }.first['url']
     else
       links.select { |link| link['kind'] == 'Download' && link['text'] == 'Data' }.first['url']
diff --git a/app/views/record/_access_button.html.erb b/app/views/record/_access_button.html.erb
index d4bf91c6..cb09dfd8 100644
--- a/app/views/record/_access_button.html.erb
+++ b/app/views/record/_access_button.html.erb
@@ -1,9 +1,9 @@
 <% return if @record.blank? %>
 
 <div class="access-button-container <%= display %>">
-  <% if access_type(@record) == 'Free/open to all' %>
+  <% if access_type(@record) == 'no authentication required' %>
     <a class="btn button-primary access-button" href="<%= gis_access_link(@record) %>">Download geodata files</a>
-  <% elsif access_type(@record) == 'MIT authentication' %>
+  <% elsif access_type(@record) == 'MIT authentication required' %>
     <a class="btn button-primary access-button" href="<%= gis_access_link(@record) %>">
       Download geodata files <span class="auth-notice">MIT authentication</span>
     </a>
diff --git a/app/views/record/_record_geo.html.erb b/app/views/record/_record_geo.html.erb
index 31f311cb..ea4a1bd1 100644
--- a/app/views/record/_record_geo.html.erb
+++ b/app/views/record/_record_geo.html.erb
@@ -42,7 +42,7 @@
     <% end %>
 
     <div class="record-access-links">
-      <% if access_type(@record) != 'Not owned by MIT' && source_metadata_available?(@record['links']) %>
+      <% if access_type(@record) != 'unknown: check with owning institution' && source_metadata_available?(@record['links']) %>
         <a class="btn button-secondary metadata-link"
            href="<%= source_metadata_link(@record['links']) %>">Download full metadata</a>
       <% end %>
diff --git a/app/views/shared/_geo_data_info.html.erb b/app/views/shared/_geo_data_info.html.erb
index 09a66401..e4b6ef18 100644
--- a/app/views/shared/_geo_data_info.html.erb
+++ b/app/views/shared/_geo_data_info.html.erb
@@ -3,12 +3,12 @@
   <% if parse_geo_dates(metadata['dates']) %>
     <li><%= parse_geo_dates(metadata['dates']) %></li>
   <% end %>
-  <% if access_type(metadata) == 'Not owned by MIT' %>
+  <% if access_type(metadata) == 'unknown: check with owning institution' %>
     <li>
-      <%= access_type(metadata) %>
+      Not owned by MIT
       <span class="other-provider">(<%= link_to "Owned by #{metadata['provider']}", gis_access_link(metadata) %>)</span>
     </li>
-  <% elsif access_type(metadata) == 'MIT authentication' %>
+  <% elsif access_type(metadata) == 'MIT authentication required' %>
     <li><span class="access-restricted"><%= access_type(metadata) %></span></li>
   <% end %>
 </ul>
diff --git a/test/helpers/record_helper_test.rb b/test/helpers/record_helper_test.rb
index f0861762..430d6ee8 100644
--- a/test/helpers/record_helper_test.rb
+++ b/test/helpers/record_helper_test.rb
@@ -122,12 +122,12 @@ class RecordHelperTest < ActionView::TestCase
                    'kind' => 'bar'
                  },
                  {
-                   'description' => 'Free/open to all',
+                   'description' => 'no authentication required',
                    'kind' => 'Access to files'
                  }
                ]
              }
-    assert_equal 'Free/open to all', access_type(rights)
+    assert_equal 'no authentication required', access_type(rights)
   end
 
   test 'gis_access_link returns nil if access type is blank' do
@@ -157,7 +157,7 @@ class RecordHelperTest < ActionView::TestCase
                             'kind' => 'bar'
                           },
                           {
-                            'description' => 'Free/open to all',
+                            'description' => 'no authentication required',
                             'kind' => 'Access to files'
                           }
                         ]
@@ -173,7 +173,7 @@ class RecordHelperTest < ActionView::TestCase
                              'kind' => 'bar'
                            },
                            {
-                             'description' => 'Not owned by MIT',
+                             'description' => 'unknown: check with owning institution',
                              'kind' => 'Access to files'
                            }
                          ],
@@ -202,7 +202,7 @@ class RecordHelperTest < ActionView::TestCase
                         'kind' => 'bar'
                       },
                       {
-                        'description' => 'Free/open to all',
+                        'description' => 'no authentication required',
                         'kind' => 'Access to files'
                       }
                     ],
@@ -226,7 +226,7 @@ class RecordHelperTest < ActionView::TestCase
                         'kind' => 'bar'
                       },
                       {
-                        'description' => 'MIT authenticated',
+                        'description' => 'MIT authentication required',
                         'kind' => 'Access to files'
                       }
                     ],