Defaults ElasticSearch log level to INFO #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our logging for ES calls was way too verbose. This defaults to INFO which seems good, but leaves the ability to easily move to DEBUG if we need the verbosity. Also clarifies how to fully disable ES logging in README.
gravesm
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logging for ES calls was way too verbose. This defaults to INFO which seems good, but leaves the ability to easily move to DEBUG if we need the verbosity.
Also clarifies how to fully disable ES logging in README.
How can a reviewer manually see the effects of these changes?
In the master branch, or in our central logging, take a look at ES queries and note that if
ELASTICSEARCH_LOGis set to anything the full es response was being logged.On this branch, set
ELASTICSEARCH_LOGto anything and note the verbosity is now at a niceINFOlevel. You can setES_LOG_LEVELtoDEBUGto easily return to the mess that was there before.Requires Database Migrations?
NO
Includes new or updated dependencies?
NO