From 6aee98d36592308df6f84f8869ee253cc7c2df9c Mon Sep 17 00:00:00 2001 From: "Saurav M. Hiremath" Date: Tue, 23 Jun 2020 23:19:24 +0530 Subject: [PATCH] fix: removed test logs and comments --- packages/jest-circus/src/utils.ts | 5 ++++- packages/jest-core/src/TestScheduler.ts | 6 ++++-- packages/jest-reporters/src/Status.ts | 4 ++-- packages/jest-reporters/src/utils.ts | 1 - packages/jest-types/src/Circus.ts | 12 +++++++++--- packages/jest-worker/src/Farm.ts | 1 - 6 files changed, 19 insertions(+), 10 deletions(-) diff --git a/packages/jest-circus/src/utils.ts b/packages/jest-circus/src/utils.ts index fa6238176b9f..7b62a457d4b0 100644 --- a/packages/jest-circus/src/utils.ts +++ b/packages/jest-circus/src/utils.ts @@ -13,6 +13,7 @@ import dedent = require('dedent'); import StackUtils = require('stack-utils'); import prettyFormat = require('pretty-format'); import type {AssertionResult, Status} from '@jest/test-result'; +import type {ParseTestResults} from '@jest/types/src/Circus'; import {ROOT_DESCRIBE_BLOCK_NAME, getState} from './state'; const stackUtils = new StackUtils({cwd: 'A path that does not exist'}); @@ -446,7 +447,9 @@ export const parseSingleTestResult = ( }; }; -export const parseTestResults = (testResults: Array) => { +export const parseTestResults = ( + testResults: Array, +): ParseTestResults => { let numFailingTests = 0; let numPassingTests = 0; let numPendingTests = 0; diff --git a/packages/jest-core/src/TestScheduler.ts b/packages/jest-core/src/TestScheduler.ts index 276b9e5baf19..653027207150 100644 --- a/packages/jest-core/src/TestScheduler.ts +++ b/packages/jest-core/src/TestScheduler.ts @@ -74,7 +74,10 @@ export default class TestScheduler { this._dispatcher.unregister(ReporterClass); } - async scheduleTests(tests: Array, watcher: TestWatcher) { + async scheduleTests( + tests: Array, + watcher: TestWatcher, + ): Promise { const onTestFileStart = this._dispatcher.onTestFileStart.bind( this._dispatcher, ); @@ -185,7 +188,6 @@ export default class TestScheduler { showStatus: !runInBand, }); - const testRunners = Object.create(null); const contextsByTestRunner = new WeakMap(); contexts.forEach(context => { diff --git a/packages/jest-reporters/src/Status.ts b/packages/jest-reporters/src/Status.ts index a57e0b1a4caf..ce0edc40650b 100644 --- a/packages/jest-reporters/src/Status.ts +++ b/packages/jest-reporters/src/Status.ts @@ -117,7 +117,7 @@ export default class Status { this._emit(); } - addTestCaseResult(test: Test, testCaseResult: TestCaseResult) { + addTestCaseResult(test: Test, testCaseResult: TestCaseResult): void { this._currentTestCases.push({test, testCaseResult}); if (!this._showStatus) { this._emit(); @@ -126,7 +126,7 @@ export default class Status { } } - testStarted(testPath: Config.Path, config: Config.ProjectConfig) { + testStarted(testPath: Config.Path, config: Config.ProjectConfig): void { this._currentTests.add(testPath, config); if (!this._showStatus) { this._emit(); diff --git a/packages/jest-reporters/src/utils.ts b/packages/jest-reporters/src/utils.ts index 59782c854a0c..9f1a4e32f543 100644 --- a/packages/jest-reporters/src/utils.ts +++ b/packages/jest-reporters/src/utils.ts @@ -127,7 +127,6 @@ export const getSummary = ( const valuesForCurrentTestCases = getValuesCurrentTestCases( options ? options.currentTestCases : [], ); - // console.log(aggregatedQuickStats.numPassingTests); const estimatedTime = (options && options.estimatedTime) || 0; const snapshotResults = aggregatedResults.snapshot; diff --git a/packages/jest-types/src/Circus.ts b/packages/jest-types/src/Circus.ts index 9b0347a22ce0..c7edf9b054bf 100644 --- a/packages/jest-types/src/Circus.ts +++ b/packages/jest-types/src/Circus.ts @@ -6,6 +6,7 @@ */ import type * as Global from './Global'; +import type {AssertionResult} from './TestResult'; type Process = NodeJS.Process; @@ -226,7 +227,12 @@ export type TestEntry = { duration?: number | null; status?: TestStatus | null; // whether the test has been skipped or run already timeout?: number; - // children: Array; // Added to include property from DescribeBlock - // hooks: Array; // Added to include property from DescribeBlock - // tests: Array; // Added to include property from DescribeBlock +}; + +export type ParseTestResults = { + assertionResults: Array; + numFailingTests: number; + numPassingTests: number; + numPendingTests: number; + numTodoTests: number; }; diff --git a/packages/jest-worker/src/Farm.ts b/packages/jest-worker/src/Farm.ts index 1f123526107d..f0109fcf3d1f 100644 --- a/packages/jest-worker/src/Farm.ts +++ b/packages/jest-worker/src/Farm.ts @@ -50,7 +50,6 @@ export default class Farm { method: string, ...args: Array ): PromiseWithCustomMessage { - const customMessageListeners: Set = new Set(); const addCustomMessageListener = (listener: OnCustomMessage) => {