Set relative path of library directory to binary directory when installing mlton script #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems (e.g., x86_64 Fedora) will set `libdir` to `/usr/lib64`, so it is necessary to compute and set the relative path from `TBIN` to `TLIB` when installing `$(TBIN)/mlton`. (For robustness, also compute and set the relative path from `BIN` to `LIB` when installing `$(BIN)/mlton`.) While GNU `realpath` would suffice, it does not exist on MacOS (and other *BSD?). A small, probably not entirely robust, shell command is constructed to compute relative paths.
See a3cccd8. Some systems (e.g., x86_64 Fedora) will set `libdir` to `/usr/lib64`, so it is necessary to compute and set the relative path from `TBIN` to `TLIB` when installing `$(TBIN)/mlton`. While GNU `realpath` would suffice, it does not exist on MacOS (and other *BSD?). A small, probably not entirely robust, shell command is constructed to compute relative paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some systems (e.g., x86_64 Fedora) want to install the library files in
/usr/lib64, rather than/usr/lib. Thus, when installing it is necessary to compute and set the relative path ofTLIBtoTBINwhen installing$(TBIN)/mlton.