/MOcov

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

BUG: Fix coverage calculation for empty files #2

Merged
merged 1 commit into from Feb 1, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@scottclowe @nno
@scottclowe
Contributor

scottclowe commented Feb 1, 2016

For files with no executable lines, the coverage report should
have a nominal 100% coverage rate. This is the behaviour of other
coverage packages, such as those for Python coverage.

Previously, files without any executable lines would report a
coverage of "NaN%", due to the division by 0.
@scottclowe scottclowe BUG: Fix coverage calculation for empty files 
For files with no executable lines, the coverage report should
have a nominal 100% coverage rate. This is the behaviour of other
coverage packages, such as those for Python.

Previously, files without any executable lines would report a
coverage of "NaN%", due to the division by 0.
41dcc01
@scottclowe
Contributor

scottclowe commented Feb 1, 2016

Had to rebase this so it will apply on top of #1. This is now done.
@nno
Contributor

nno commented Feb 1, 2016

Thanks for the rebase and the fix.

@nno nno added a commit that referenced this pull request Feb 1, 2016

@nno nno Merge pull request #2 from scottclowe/fix-empty-coverage 
BF: Fix coverage calculation for empty files
 924fd09

@nno nno merged commit 924fd09 into MOcov:master Feb 1, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@scottclowe scottclowe deleted the scottclowe:fix-empty-coverage branch Feb 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment