-
Notifications
You must be signed in to change notification settings - Fork 53
Fix first file for time series #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This merge makes the range of files printed in the log ignore the first year if it is not in the requested range, even though it gets added to allow anomaly computations.
|
@milenaveneziani, I think you can just approve this one by inspection. I have confirmed in a small test (running with time series computed over years 2 to 5 for the QU240 test case) that the expected output is now produced: |
milenaveneziani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xylar.
|
oh, forgot to mention: the same happens in mpas_climatology. Could you please make the same change there? |
|
Here: MPAS-Analysis/mpas_analysis/shared/climatology/mpas_climatology_task.py Lines 162 to 164 in 8374b59
|
|
@milenaveneziani, are you quite sure? The climatology shouldn't add the first year to the input files so there's no reason I can see why the list of input files wouldn't be correct. I'll check for myself. |
|
I see the expected output for climatologies, e.g.: when I request years 2-50 (but only 1-5 are available). |
|
hmm, I thought I had seen a similar message with the climos. Never mind. Thanks for addressing this so quickly. |
|
Thanks for the quick review. |
This merge makes the range of files printed in the log ignore the first year if it is not in the requested range, even though it gets added to allow anomaly computations.