-
Notifications
You must be signed in to change notification settings - Fork 53
Read meridional heat transport lat bins from either of 2 streams #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mark-petersen, I know we don't have any output with the latitude bins in In the meantime, you can make sure that an existing run of your choice still produces the MHT plot as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is perfect. Since it is optional it is best to put it in now. Thanks for your quick action and testing here. Please merge.
|
We should have the test run with the new output sometime today, so we can test this then. |
|
Yes, we need to test this on the new output once it's available. Merging now an fixing later doesn't really save us any time. |
To save the bother of writing out the MHT stream just for the latitude bins, these bins can now (optionally) be read from the timeSeriesStatsMonthlyOutut stream instead. The refZMid, refBottomDepth and refThickness are read or computed from a restart file instead of the MHT stream.
b7fc73d to
0d3b64c
Compare
|
@milenaveneziani, do you remember what the status of testing this PR is? I lost track of it. |
|
We do have the new data to test it with. |
Testing ContinuedFor the first 2 years of a QU240 run, everything seems to work both for MPAS-Analysis/develop and for this branch. develop: http://portal.nersc.gov/project/acme/xylar/a24w_develop/ new branch: http://portal.nersc.gov/project/acme/xylar/a24w_update_source/ I also ran a test where I manually made sure the code doesn't use the MHT stream and that also worked fine. So I think MPAS-Analysis should work fine with these changes. |
Yes, the 2 PRs are independent so we can merge as soon as we're confident in the results. Which I think we are. |



To save the bother of writing out the MHT stream just for the latitude bins, these bins can now (optionally) be read from the
timeSeriesStatsMonthlyOututstream instead.The
refZMid,refBottomDepthandrefThicknessare read or computed from a restart file instead of the MHT stream.