Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Feb 27, 2024

😭😭😭😭😭

Checklist

  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes

@xylar xylar added bug Something isn't working ocean labels Feb 27, 2024
@xylar xylar self-assigned this Feb 27, 2024
Comment on lines +226 to +227
ds[field] = -(latent_heat_of_fusion *
ds.dataLandIceFreshwaterFlux)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darincomeau and @cbegeman, could you just review this by inspection when you can?

I will post output later this evening.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar Yes, I think this is exactly what we want. this is probably obvious, but when you do run the simulations, make sure the conservation AM is on.

Copy link
Collaborator

@darincomeau darincomeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @xylar ! Presumably the file in E3SM-Project/E3SM#6256 will then be updated? It'll be easy for me to re-run that case.

@xylar
Copy link
Collaborator Author

xylar commented Feb 27, 2024

Testing

I ran this on the Icos mesh and I'm seeing:

Area of a cell (m^2):             3686400.0
Total flux on plane (kg/s):       30023072.2
Total flux on sphere (kg/s):      30023072.2
Total heat flux on sphere (W):    -10018699206457.0

(I've since changed this to TW for readability.) This seems like the right sign and size of the heat flux, given the mass flux.

@xylar xylar merged commit 87c5b3b into MPAS-Dev:main Feb 27, 2024
@xylar xylar deleted the fix-sign-of-dismf-heat branch February 27, 2024 21:55
@xylar
Copy link
Collaborator Author

xylar commented Feb 27, 2024

I updated the DISMF files for Icos30, SORRM and RRS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ocean

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants