-
Notifications
You must be signed in to change notification settings - Fork 25
Touch-Ups of Geographical Features for E3SM V2 #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This version has geometric features changes from MPAS-Dev/geometric_features#147 that improve the representation of England, Scotland, Italy and Hawaii
Mesh ResultsWC14 r04EC30to60@proteanplanet, I'll let you assess but my sense is that Italy, England and Scotland look good but Hawaii still needs work. I wonder if making the shape at least for the Big Island more of a loop instead of a line would help. |
|
The results are on IC at: WC14 r04: EC30to60: |
|
To be honest, if Hawaii is a priority, the better way to handle it would be giving it at least a bit more resolution. |
|
Thank you @xylar. Your turnaround time is remarkable. I'm on annual leave this week, but will try to sneak in a quick look at the mesh in the evening on Monday or Tuesday. Hawaii may be OK, so long as the islands fall within the 20m isobath, even if they don't reveal themselves. However, I'm with you that a little resolution in this case may not hurt in this one special case, being a state. The others (Italy, Britain) look fine. |
|
@xylar and @proteanplanet regarding Hawaii, I would pretty strongly prefer not increasing resolution around Hawaii. In my view Hawaii is a pretty low priority for water cycle science questions, even though it is a state. |
@proteanplanet, this is with the 60-layer vertical grid so the shallowest non-land bathymetry will be about 30 m deep. Just keep that in mind.
@vanroekel, okay, noted. |
mark-petersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@proteanplanet Thanks for your attention to these details. That English Channel was in the first set of channels we ever specified, and I was just centering between coastlines, not isobaths. Your method here is better.
We might as well merge this, so it is in for the next mesh generation. @xylar and @vanroekel did you have other comments?
|
@mark-petersen yes I think it is fine to merge, but we should verify @proteanplanet doesn't want to tweak the shape file for Hawaii anymore. |
|
@xylar, @mark-petersen, @vanroekel - Thanks for checking. Please proceed, and thanks for taking this on. I'm fine with all of this. As far as Hawaii goes, the WC14 mesh is registering an improvement in bathymetry which is fine at this resolution. There are other applications (tides) where we will be increasing the resolution in these areas and using nearby long tidal gauge records, for which the Hawaii improvements will be most visible at higher resolution. |
|
I'm not going to make a new release of |





This pull request is to be included in WC14r04 for E3SM V2 should we decide to shift to a new revision for other reasons, such as for changes in vertical resolution. This pull request is also to ensure that future mesh generation permits the included refinements for tidal model meshes during ICoM experimentation. The reasons for the changes suggested in this pull request are threefold: 1) To ensure that boundary conditions for tides are as accurate as possible at low resolution for dissipative tests; 2) To ensure that all U.S. states, including Hawaii, are represented in E3SM to the best of our ability; and 3) To make sure that highly recognizable geographic features, including Hawaii, the British Isles and the Mediterranean are equally as recognizable on E3SM and MPAS meshes for high level briefings and outreach purposes. This pull request includes four elements:
a) An attempt to fix the English Channel, which for some reason is heavily widened in WC14r03 and previous meshes at the Pas de Calais as compared to the real world. The English_Channel_Deepen addition of @mark-petersen has been altered to include a higher resolution and slightly shallower transect (100m versus 120m). Should this also prove inadequate, then there may be other problems with geometric features prescribed in the Channel. The fix is annotated here:
b) A fix to the Inner Hebrides so that the Firth of Lorn appears at standard resolution (which it should):
c) Fix to Southern Italy so that Sicily, Salento, and Calabria are properly resolved at standard resolution:
d) Fix to Hawaii to ensure that all of Hawai'i, Moloka'i, Maui, O'ahu, and Kaua'i appear on standard resolution maps, so that the state appears in Water Cycle simulations, but also so that sufficient boundary conditions exist in resolution tests on key amphidromic points in the Pacific during resolution degradation tests with tides in E3SM.
This pull request has only a moderate priority, but should we choose to shift to WC14r04, the priority would elevate. Parts (b)-(d) will most likely have a relatively straight-forward impact on the meshes. However, part (a) will need to be carefully checked to understand if the change had any impact.