Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Nov 23, 2020

This merge adds aggregation for:

  • Antarctic regions
  • Ocean basins
  • Ice shelves
  • Transport transects
  • MOC basins

@pep8speaks
Copy link

pep8speaks commented Nov 23, 2020

Hello @xylar! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-25 11:32:24 UTC

@xylar xylar self-assigned this Nov 23, 2020
@xylar xylar force-pushed the add_more_aggregation branch from 7c47493 to 5c01dbf Compare November 23, 2020 13:31
@xylar
Copy link
Collaborator Author

xylar commented Nov 23, 2020

@milenaveneziani, we had discussed in June (MPAS-Dev/MPAS-Analysis#710 (comment), MPAS-Dev/MPAS-Analysis#712) that it would be really important to have some provenance for the Arctic regions. I had made a draft of what I thought the regions might be but you had mentioned (MPAS-Dev/MPAS-Analysis#710 (comment)) that the regions as you defined them were a little more complicated than this. Could you modify the last commit here to so the aggregator at geometric_features/aggregation/ocean/arctic_regions.py recreates the Arctic regions used in MPAS-Analysis?

@xylar
Copy link
Collaborator Author

xylar commented Nov 24, 2020

This PR still needs to add some documentation on the aggregation functions, how to use them, and how to add new ones.

@xylar xylar force-pushed the add_more_aggregation branch 2 times, most recently from 7e2505e to 30743a7 Compare November 24, 2020 13:09
@xylar xylar force-pushed the add_more_aggregation branch from 30743a7 to f9b77d0 Compare November 25, 2020 11:32
@xylar xylar removed the request for review from milenaveneziani November 25, 2020 11:33
@xylar
Copy link
Collaborator Author

xylar commented Nov 25, 2020

@milenaveneziani, I'm taking out the Arctic regions for this PR and release. I'll follow up with you about those in the next few weeks.

@xylar xylar merged commit 37505ae into MPAS-Dev:master Nov 25, 2020
@xylar xylar deleted the add_more_aggregation branch November 25, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants