Skip to content

Conversation

@xylar
Copy link
Collaborator

@xylar xylar commented Jan 30, 2021

These features are the ones used to select CMIP5/6 models for ocean forcing in the ISMIP6 project. They will be used for analysis in a paper that is in progress.

This merge also adds a creation script for these features.

@xylar xylar requested a review from alicebarthel January 30, 2021 20:36
@xylar xylar self-assigned this Jan 30, 2021
@xylar
Copy link
Collaborator Author

xylar commented Jan 30, 2021

@alicebarthel, this PR adds the features we discussed to geometric_features. It will require another step (which I will take care of) to be able to use them in MPAS-Analysis.

For now, I would like you to take a careful look at each of these 6 (just on GitHub is fine) and make sure they make sense:
https://github.com/MPAS-Dev/geometric_features/blob/8459c5f498ffaef3e7ca365a7aef407f09caf5a6/geometric_data/ocean/region/ISMIP6_Amery_Sector_Shelf/region.geojson

https://github.com/MPAS-Dev/geometric_features/blob/8459c5f498ffaef3e7ca365a7aef407f09caf5a6/geometric_data/ocean/region/ISMIP6_Amundsen_Sea_Shelf/region.geojson

https://github.com/MPAS-https://github.com/MPAS-Dev/geometric_features/blob/8459c5f498ffaef3e7ca365a7aef407f09caf5a6/geometric_data/ocean/region/ISMIP6_Totten_Region_Shelf/region.geojson

https://github.com/MPAS-Dev/geometric_features/blob/8459c5f498ffaef3e7ca365a7aef407f09caf5a6/geometric_data/ocean/region/ISMIP6_Weddell_Sea_Shelf/region.geojson

https://github.com/MPAS-Dev/geometric_features/blob/8459c5f498ffaef3e7ca365a7aef407f09caf5a6/geometric_data/ocean/region/ISMIP6_Ross_Sea/region.geojson

The Ross is divided into 2 halves because it crosses the date line (antemeridian). That's just a weird requirement of geojson files.

Here's a polar stereographic image for reference:

ISMIP6_regions

The other feedback I need from you is what zmin and zmax should be. Currently, they're -1000 and -200, but that's just because that happened to be what we used for the shelf in our previous Antarctic shelf regions.

@alicebarthel
Copy link

Xylar, the regions look good. Maybe some marginal differences but I reckon due to the plotting and topo, as the values shown in the raw geojson files correspond to the ones I have given. Please just clarify the continental shelf threshold when you can (it should be 1500m).

@xylar xylar force-pushed the add_ismip6_regions branch from 4bce5c6 to b59d5e3 Compare February 1, 2021 20:32
@xylar
Copy link
Collaborator Author

xylar commented Feb 1, 2021

@alicebarthel, thanks for the review! I'm going to do a test to make sure this works in MPAS-Analysis before I merge this PR and make the release. It's a lot of work if I find out later that I made a mistake...

@xylar
Copy link
Collaborator Author

xylar commented Feb 1, 2021

Merging based on testing in MPAS-Dev/MPAS-Analysis#777

@xylar xylar merged commit e429501 into MPAS-Dev:master Feb 1, 2021
@xylar xylar deleted the add_ismip6_regions branch February 1, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants