Skip to content

Conversation

@milenaveneziani
Copy link
Collaborator

This adds two new transect features to standard_transport_sections: the OSNAP arrays West (Newfoundland to Greenland) and East (Greenland to Scotland). A plot of the transects is included below.
Screen Shot 2021-03-22 at 8 50 23 PM
Screen Shot 2021-03-22 at 8 50 05 PM

@pep8speaks
Copy link

pep8speaks commented Mar 23, 2021

Hello @milenaveneziani! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:1: E722 do not use bare 'except'
Line 49:81: E501 line too long (81 > 80 characters)
Line 83:81: E501 line too long (81 > 80 characters)

Comment last updated at 2021-03-23 14:52:22 UTC

@milenaveneziani
Copy link
Collaborator Author

@xylar: here are the transect additions we discussed over email. I think I have followed the correct workflow, but let me know if you have any comments. Thanks.

@milenaveneziani
Copy link
Collaborator Author

I decided to make a new tag for these sections: arctic_sections, so that we can make a separate arctic_sections file and not add these to the standard_transport_sections that we normally use for computing volume transport in MPAS-Analysis.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great as well!

@milenaveneziani milenaveneziani merged commit 3bafabf into MPAS-Dev:master Mar 23, 2021
@milenaveneziani
Copy link
Collaborator Author

Thanks @xylar!

@milenaveneziani milenaveneziani deleted the addOSNAPsections branch March 23, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants