Add MOC Basins to aggregation by name #169
Conversation
|
@milenaveneziani, do you just want to review this by inspection? No need to do any testing. |
milenaveneziani
left a comment
milenaveneziani
left a comment
There was a problem hiding this comment.
sure. Looks good.
| 'MOC Basins': {'prefix': 'mocBasins', | ||
| 'date': '20210331', |
There was a problem hiding this comment.
Mask files without the southern transects will be named <mesh>_mocBasins20210331.nc. Then, the ones with the southern transect (calculated via MPAS-Tools) will be <mesh>_mocBasinsAndTransects20210331.nc. Does that seem right?
There was a problem hiding this comment.
I wonder if we need both? just _mocBasinsAndTransects would be enough in my view, since these masks are only used in the MOC and MHT am's?
There was a problem hiding this comment.
As a practical consideration, at the moment I don't have a good way of checking if <mesh>_mocBasinsAndTransects20210331.nc and not creating <mesh>_mocBasins20210331.nc if it does. I'll have to think about how to do this without making things unnecessarily complicated.
There was a problem hiding this comment.
Never mind, that's quite easy to handle.
|
Tested with MPAS-Analysis on QU480 and QU240wLI meshes. More testing will be performed after a release. |
2 participants
The MOC basins are given a date stamp like other regions. This will also make it easier to make masks for them in the same way we make other region masks.