Add Atlantic MOC without Mediterranean #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the new default "Atlantic" MOC region, and the version that includes the Mediterranean is now "AtlanticMed". This merge updates the date stamp for the `mocBasins` aggregator to today's date.
This was referenced Jun 23, 2021
Collaborator
|
@xylar this looks perfect! Here are some plots, first for EC30to60 Old region definition of Atlantic
New file of Atlantic
And New file but AtlanticMediterranean
Here is the same but for WC14 Old
New
New, but AtlanticMed
|
vanroekel
approved these changes
Jun 23, 2021
Collaborator
vanroekel
left a comment
vanroekel
left a comment
There was a problem hiding this comment.
Looks great to me. Approving on visual inspection and examination of basin files
Collaborator
Author
|
@milenaveneziani, would you have time to review this today? If not, I'll be happy with @vanroekel's review. But it would be really good to have another pair of eyes on this if you do have a chance. |
Collaborator
|
Looks great @xylar, thanks. |
milenaveneziani
approved these changes
Jun 23, 2021
Collaborator
Author
|
Thanks @vanroekel and @milenaveneziani for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new default "Atlantic" MOC region, and the version
that includes the Mediterranean is now "AtlanticMed".
This merge updates the date stamp for the
mocBasinsaggregatorto today's date.
This merge also updates the
geometric_featuresversion number to 0.5.0, in anticipation of a release immediately after this PR.