Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies after deleting item list for suggestions for organizations #1157

Open
hofmannc opened this issue Sep 9, 2019 · 1 comment

Comments

@hofmannc
Copy link

commented Sep 9, 2019

Testserver: qa imeji
Browser: ff
Version: 4.6 - build date 2019-08-30 12:57:36
User: admin

Actions: Configuration -> System configuration -> Automated suggestion ->
"Enable suggestion for Organizations by a list of Organizations (use one value per line)" -> enter list of items -> save ->
items of list are implemented in Automatic suggestion of "edit collection" information

go back to configuration site -> delete list -> save

Observation:
"Enable suggestion for Organizations (disabled if a list of Organizations is defined) " -> radio buttons are deactivated and
with first try: in "edit collection information" -> no selection available, only after returning several times, the radiobuttons were selectable again
with second try: in "edti collection information" -> selection menue available, but empty

Expected Result:
I can select radio buttons right after deleting the item list

@hofmannc hofmannc added the bug label Sep 9, 2019
@haarli haarli added this to To do in imeji 4.7 Sep 16, 2019
@helkv helkv moved this from To do to In progress in imeji 4.7 Sep 23, 2019
helkv added a commit that referenced this issue Oct 9, 2019
-> Add additional radio button "Separate list of organizations"
-> The organisations-list is only visible if the "Separate list of
organizations" button is selected
- Add new values for the "Enable suggestion for Organizations" radio
buttons
- The "AUTOSUGGEST_ORGAS" property is set to "none" as default value
- Reworked person.xhtml according to the changes in AdminConfig.xhtml
@helkv

This comment has been minimized.

Copy link

commented Oct 9, 2019

Reworked the 'Enable suggestion for Organizations' functionality:

  • Add new option "Separate list of organizations" for 'Enable suggestion for Organizations'
    • If this option is selected the list of organizations ('Separate list of Organizations for suggestion') is visible and editable (otherwise its not visible)
  • The 'Organization' field for person (in Create/Edit Collection view & Create/Edit User view) has the autosuggest functionality, depending on the selected option for 'Enable suggestion for Organizations':
    • Option 'None' - No autosuggest
    • Option 'imeji internal organizations' - autosuggest using the organizations of the imeji users
    • Option 'Separate list of organizations' - autosuggest using the organizations defined in 'Separate list of Organizations for suggestion'

If an own list of organizations was already defined (before these changes, imeji 4.7) the new 'Separate list of organizations' option must be selected (and saved) to activate the list for autosuggest -> see: imeji GitHub wiki Release checklists -> imeji 4.7.

helkv added a commit that referenced this issue Oct 11, 2019
- Rework the input text field for organization in person.xhtml. Now the
input text field is always rendered, even if an unexpected
'autosuggestForOrganizations'-value is used for the render condition.
- Reused 'imeji_orgs' as 'imeji internal organizations'-value in config,
for downward compatibility
@helkv helkv moved this from In progress to Done in imeji 4.7 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
imeji 4.7
  
Done
2 participants
You can’t perform that action at this time.