New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Pushover.net notifications #2539

Closed
blondak opened this Issue Jan 11, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@blondak
Contributor

blondak commented Jan 11, 2017

Add options to send user notifications using https://pushover.net/

@TheSerapher

This comment has been minimized.

Show comment
Hide comment
@TheSerapher

TheSerapher Jan 12, 2017

Contributor

Looks cool even though it does cost money if users want to stick to it. Not sure if many are willlong to pay for something as simple as notifications if a simple Mail would do the trick.

Anyway leaving it open if someone feels like tackling this.

Contributor

TheSerapher commented Jan 12, 2017

Looks cool even though it does cost money if users want to stick to it. Not sure if many are willlong to pay for something as simple as notifications if a simple Mail would do the trick.

Anyway leaving it open if someone feels like tackling this.

@blondak

This comment has been minimized.

Show comment
Hide comment
@blondak

blondak Jan 12, 2017

Contributor

Or maybe some universal interface for custom classes, basically implement and define some INTERFACE and user can write own class (XMPP, Pushover.net, etc...)

Contributor

blondak commented Jan 12, 2017

Or maybe some universal interface for custom classes, basically implement and define some INTERFACE and user can write own class (XMPP, Pushover.net, etc...)

@TheSerapher

This comment has been minimized.

Show comment
Hide comment
@TheSerapher

TheSerapher Jan 12, 2017

Contributor

Not sure if someone would tackle that, but the only place I can see that needs to be more generic is the sendNotifications task:

https://github.com/MPOS/php-mpos/blob/master/include/classes/notification.class.php#L140-L166

It's setup for mails only right now but it shouldn't be too hard to make it more generic to accept some basic data and then act :-)

Contributor

TheSerapher commented Jan 12, 2017

Not sure if someone would tackle that, but the only place I can see that needs to be more generic is the sendNotifications task:

https://github.com/MPOS/php-mpos/blob/master/include/classes/notification.class.php#L140-L166

It's setup for mails only right now but it shouldn't be too hard to make it more generic to accept some basic data and then act :-)

@blondak

This comment has been minimized.

Show comment
Hide comment
@blondak

blondak Jan 12, 2017

Contributor

ok, I'm doing on it ;)

Contributor

blondak commented Jan 12, 2017

ok, I'm doing on it ;)

@TheSerapher

This comment has been minimized.

Show comment
Hide comment
@TheSerapher

TheSerapher Jan 12, 2017

Contributor

Awesome, be sure to PR it against the development brach here so we can run it against the community before we release it :-)

Contributor

TheSerapher commented Jan 12, 2017

Awesome, be sure to PR it against the development brach here so we can run it against the community before we release it :-)

blondak pushed a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 12, 2017

blondak added a commit to blondak/php-mpos that referenced this issue Jan 17, 2017

TheSerapher added a commit that referenced this issue Feb 28, 2017

Merge pull request #2540 from blondak/development
#2539 - Feature request: Pushover.net notifications
@TheSerapher

This comment has been minimized.

Show comment
Hide comment
@TheSerapher

TheSerapher Jul 16, 2017

Contributor

I am closing all old feature requests and ideas since it doesn't seem that anyone is doing a PR against those anyway. Since I won't have the time, no need to keep these ideas open if they are not eventually being implemented.

Contributor

TheSerapher commented Jul 16, 2017

I am closing all old feature requests and ideas since it doesn't seem that anyone is doing a PR against those anyway. Since I won't have the time, no need to keep these ideas open if they are not eventually being implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment