[FIX] delete whitespaces in uptimerobot api keys #1896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should also be done before storing them to DB. |
Contributor
Author
|
doesn't work for uptimerobot api key, because it's a complete string, not divided in separate strings like in monitoring class. |
Contributor
|
True but preg_replace can just remove all spaces for us :-) |
TheSerapher
added a commit
that referenced
this pull request
Mar 6, 2014
[FIX] delete whitespaces in uptimerobot api keys
Contributor
Author
|
sure, but removing all spaces will cut down whitespaces in site title or motd and so on :) |
Contributor
|
I meant during storage. Take the string to be stored and remove any spaces from it before a writing into the DB. Not on the page itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.