Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cblas calls, use EIGEN_USE_BLAS instead. #82

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

susilehtola
Copy link

As requested in #81, this is a pull request that eliminates CBLAS in favor of BLAS support inside Eigen3.

Note that to actually compile the code against the present version of Eigen3, you need to address a bug in Eigen3 by adding a missing include statement

$ hg diff
diff -r 3a08a093adac Eigen/src/Core/products/TriangularMatrixMatrix_BLAS.h
--- a/Eigen/src/Core/products/TriangularMatrixMatrix_BLAS.h     Mon Apr 09 13:29:26 2018 +0200
+++ b/Eigen/src/Core/products/TriangularMatrixMatrix_BLAS.h     Tue Apr 10 15:51:12 2018 +0300
@@ -33,6 +33,8 @@
 #ifndef EIGEN_TRIANGULAR_MATRIX_MATRIX_BLAS_H
 #define EIGEN_TRIANGULAR_MATRIX_MATRIX_BLAS_H

+#include "../../misc/blas.h"
+
 namespace Eigen {

 namespace internal {

@robertodr
Copy link
Contributor

Which version of Eigen is bugged? I can link against BLAS with Eigen 3.3.3 without problems. @stigrj maybe it's time to update Eigen?

@susilehtola
Copy link
Author

Mine failed with Eigen 3.3.4 as well as the head branch, with gcc 7.3.1.

@robertodr
Copy link
Contributor

Weird... I'm in favor of pulling this in as-is and then figuring out the issue. @stigrj?

P.S.: The example I was compiling is this one

Copy link
Contributor

@stigrj stigrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, -100 lines of code = gold

@stigrj stigrj merged commit 3efb2a4 into MRChemSoft:master Apr 10, 2018
@susilehtola susilehtola deleted the eigen branch April 10, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants