New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename WithoutLabel to WithoutLabelElement and deprecate it #122
Comments
GetLabelHtml returns not empty string if Display Attribute present
GetLabelHtml returns not empty string if Display Attribute present
I think this is a misunderstanding maybe? |
Hm that makes sense. Maybe it should be named WithoutLabelTag? Or maybe add clarification to the documentation. |
I agree that I'm hesitant to make a breaking rename change because this code is called from razor views which most people don't compile. We could create an alias name that is easier to understand though (but simply calls As to what the method should be called. What about |
GetLabelHtml returns not empty string if Display Attribute present
Fix according to last comment |
Here is a test in DefaultFieldGeneratorTest that fails:
The text was updated successfully, but these errors were encountered: