Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CDisplayWindowPlots -> qwt #107

Open
jlblancoc opened this issue Dec 18, 2014 · 7 comments
Open

Port CDisplayWindowPlots -> qwt #107

jlblancoc opened this issue Dec 18, 2014 · 7 comments
Assignees
Labels
enhancement help wanted We seek help from someone willing to work on this topic!

Comments

@jlblancoc
Copy link
Member

jlblancoc commented Dec 18, 2014

Much nicer & modern lib.

Port wxWidgets-based GUI -> qt + qwt

@jlblancoc jlblancoc self-assigned this Dec 18, 2014
@jlblancoc jlblancoc added this to the Release 1.3.0 milestone Dec 18, 2014
@jlblancoc jlblancoc removed this from the Release 1.3.0 milestone Dec 31, 2014
@jlblancoc jlblancoc changed the title Port wxMath -> libmgl (MathGL) Port CDisplayWindowPlots -> QCustomPlot May 21, 2015
@jolting
Copy link
Member

jolting commented May 30, 2017

Maybe @LisGein might be able to take a look at this.

@LisGein
Copy link
Contributor

LisGein commented May 31, 2017

I want to note that 2D and 3D graphics are inherited in Qt from different classes.
Also you can't use Q3DSurface and Q3DScatter in a single widget together. I encountered an this problem in my project.

@jlblancoc
Copy link
Member Author

jlblancoc commented May 31, 2017 via email

@LisGein
Copy link
Contributor

LisGein commented May 31, 2017

What about license? QCustomPlot has GNU GPL...

@jlblancoc
Copy link
Member Author

Good point Lis, didn't see it! :-(

Well, firstly: we want MRPT to remain with BSD license.

So, for sure, including QCustomPlot would propagate the GNU GPL license to the entire project (as far as I understand it), if:

  • We include its source code, or
  • We include its binary form.

That would apply to Windows binary releases (the sources could be left as to be downloaded by the interested user).
But, I think that if we only build and link against system packages of this library, using dynamic linking, we could be "safe".

I have seen different opinions about this over the years. I even recall asking this very exact question to Richard Stallman during an interview in a visit to my town, and his answer could be summarized as: "yes, GNU GPL would apply in any case [static vs. dynamic linking]". But I'm not 100% satisfied with this idea because... then it would be impossible to release any BSD package (e.g. Debian, Ubuntu) as long as they link against one single GNU GPL library (!!).

Your thoughts? :-) (cc: @jolting )

@jolting
Copy link
Member

jolting commented Jun 1, 2017

Technically, the 3-clause BSD license is compatible with the GPL. Conceivable it is possible to ship various MRPT components under different licenses, but this gets tricky. You shouldn't need to be a lawyer to use MRPT.

Alternatives:

  • QtChart
    In 5.6 Qt started supporting the QtChart Library. Unfortunately, It appears that is GPL3[1] which is strange because most of their other libraries are LGPL. Some of the comments on their blog talk about the issues people are having with the choice to license under GPL[2]. It seems to me this was a poor decision on their part. Also, I'd prefer not use it because 16.04 didn't ship with a recent enough version.

  • qwt
    I propose Qwt which is already packaged in 16.04, so using it (on Linux) will be much easier. It also has an LGPL license, which won't cause MRPT to inherit the GPL3 license.

[1] https://github.com/qt/qtcharts/blob/dev/LICENSE.GPL3
[2] http://blog.qt.io/blog/2016/01/18/qt-charts-2-1-0-release/

@jlblancoc
Copy link
Member Author

👍 for qwt. Should do the job!

@jlblancoc jlblancoc changed the title Port CDisplayWindowPlots -> QCustomPlot Port CDisplayWindowPlots -> qwt Jun 2, 2017
@jlblancoc jlblancoc added the help wanted We seek help from someone willing to work on this topic! label Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted We seek help from someone willing to work on this topic!
Projects
None yet
Development

No branches or pull requests

3 participants