Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There might be a little mistake in CICP::ICP_Method_LM #1264

Closed
ysklab opened this issue Jan 5, 2023 · 1 comment
Closed

There might be a little mistake in CICP::ICP_Method_LM #1264

ysklab opened this issue Jan 5, 2023 · 1 comment

Comments

@ysklab
Copy link

ysklab commented Jan 5, 2023

In function "CICP::ICP_Method_LM", branch "develop", line 597:

matchParams.angularDistPivotPoint =
		TPoint3D(q.x(), q.y(), 0);	// Pivot point for angular measurements

The value "q" is not initialized (so it's zero?). I guess the "angularDistPivotPoint" should be the scan center's position in map, which should not be zero.

Compared with "CICP::ICP_Method_Classic", the "angularDistPivotPoint" is set to

matchParams.angularDistPivotPoint = TPoint3D(
				gaussPdf->mean.x(), gaussPdf->mean.y(),
				0);	 // Pivot point for angular measurements

and the "guessPdf" is the initial pose given.

@jlblancoc
Copy link
Member

@ysklab thanks, indeed that was the case. Fixed via c774d05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants