Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[png.c:4829]: (style) Array index 'i' is used before limits check. #34

Closed
dcb314 opened this issue Mar 21, 2014 · 3 comments
Closed

[png.c:4829]: (style) Array index 'i' is used before limits check. #34

dcb314 opened this issue Mar 21, 2014 · 3 comments

Comments

@dcb314
Copy link

@dcb314 dcb314 commented Mar 21, 2014

Source code is

    for (i = 1; (tmp[i] == k) && (i < j); i++);

Maybe better code might be

    for (i = 1; (i < j) && (tmp[i] == k); i++);
@jlblancoc
Copy link
Member

@jlblancoc jlblancoc commented Mar 21, 2014

I think you opened the issue against the wrong project, may it be?? MRPT doesn't have a "png.c" file, as far as I remember!! :-)

@dcb314
Copy link
Author

@dcb314 dcb314 commented Mar 22, 2014

I think you opened the issue against the wrong project

Agreed. Should be mtpaint, not mrpt. My apologies for the error.

@jlblancoc
Copy link
Member

@jlblancoc jlblancoc commented Mar 22, 2014

It's fine!

@jlblancoc jlblancoc closed this Mar 22, 2014
jlblancoc pushed a commit that referenced this issue Aug 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants