Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS Mojave dark mode issues #1520

Closed
bjeurissen opened this Issue Dec 15, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@bjeurissen
Copy link
Member

bjeurissen commented Dec 15, 2018

On macOS Mojave, dark mode was introduced. Using Qt version < 5.12, this results in text and background having the same colour sometimes, making the text completely illegible.

The good news is that updating to Qt 5.12 fixes those issues, resulting in a good dark mode experience.

However, there is one area where text to background contrast is not optimal and that is the text next to the buttons in the button bar:
screenshot 2018-12-15 at 11 17 36

Not sure if this is something that we can/need to fix ourselves or something that will fix itself over time. Is there something different with the text setup for the button bar?

@jdtournier

This comment has been minimized.

Copy link
Member

jdtournier commented Dec 17, 2018

We don't do anything particularly exotic on that front. This is where the the top bar is set up (menus are added as buttons with drop down menus). This one is up to Qt, I reckon...

@bjeurissen

This comment has been minimized.

Copy link
Member Author

bjeurissen commented Dec 17, 2018

That looks indeed harmless, there is nothing related to colour there... It's indeed up to Qt.

@bjeurissen bjeurissen closed this Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.