Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foreach: foreach is a shell reserved word in zsh #1708

Closed
bjeurissen opened this issue Sep 7, 2019 · 4 comments
Closed

foreach: foreach is a shell reserved word in zsh #1708

bjeurissen opened this issue Sep 7, 2019 · 4 comments

Comments

@bjeurissen
Copy link
Member

@bjeurissen bjeurissen commented Sep 7, 2019

foreach is a reserved keyword in zsh, which makes our script with the same name only available as command foreach. This is not a huge deal, but we should be aware that on future macos versions, zsh will become the default shell instead of bash (https://support.apple.com/en-ca/HT208050?fbclid=IwAR0Z1-TK9h3oInv_byv9fDa9EbxxxZoqSaI4Osfq5_fxDi7jXvKjS3YAKvk). Maybe we should consider renaming foreach to something slightly more exotic?

@Lestropie

This comment has been minimized.

Copy link
Member

@Lestropie Lestropie commented Sep 7, 2019

😬

@maxpietsch

This comment has been minimized.

Copy link
Member

@maxpietsch maxpietsch commented Sep 16, 2019

  • feach, for_each
  • fordo
  • applyto
  • lsdo
  • iterdo
  • map
  • itermap
  • listmap
  • seqmap
@maxpietsch maxpietsch added this to the MRtrix3 3.0 release milestone Jan 23, 2020
@maxpietsch

This comment has been minimized.

Copy link
Member

@maxpietsch maxpietsch commented Jan 27, 2020

Any opinions on what to rename foreach to?

@Lestropie

This comment has been minimized.

Copy link
Member

@Lestropie Lestropie commented Jan 28, 2020

Given existing user familiarity, and the absence of an unambiguous better solution, I'm probably leaning towards for_each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.