Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation for -nthreads #1716

Closed
thijsdhollander opened this issue Sep 11, 2019 · 3 comments

Comments

@thijsdhollander
Copy link
Contributor

commented Sep 11, 2019

  -nthreads number
     use this number of threads in multi-threaded applications (set to 0 to
     disable multi-threading).

However, 0 does not disable multi-threading; rather, it fully unleashes it.

I reckon the behaviour is fine, but the documentation doesn't match it.

@thijsdhollander thijsdhollander added the bug label Sep 11, 2019

@thijsdhollander

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Feel free to label as you wish. I had no other options; this seemed to fit "Create a report to help us improve" best. 🤷‍♂

@thijsdhollander

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Ok, so it's a bit more nuanced. Thanks to this user/post on the forum, I've come to realise the setting of this issue only applies to scripts currently. That probably changes what I would suggest to be the solution: maybe then, the documentation is ok (for binaries, there is a match between documentation and behaviour currently), but the behaviour for the scripting library currently isn't. Or you could rethink from scratch of course what you want -nthreads 0 to be in practice. All up to you.

@thijsdhollander

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2019

Should be fixed by #1717 ; closing this. Happy to have contributed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.