Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove naked except: statements from python scripts #1402

Closed
wants to merge 1 commit into from

Conversation

@jdtournier
Copy link
Member

jdtournier commented Jul 18, 2018

As discussed in #1391

Now using 'except: Exception' as a catch-all instead. This will not catch KeyboardInterrupt, SystemExit, or GeneratorExit exception, since by design these derive from BaseException directly - precisely to ensure they don't get caught by an except: Exception statement.

As discussed in #1391

Now using 'except: Exception' as a catch-all instead. This will not
catch KeyboardInterrupt, SystemExit, or GeneratorExit exception, since
by design these derive from BaseException directly - precisely to ensure
they don't get caught by an 'except: Exception' statement.
@jdtournier jdtournier changed the title remove naked excecpt: statements from python scripts remove naked except: statements from python scripts Jul 18, 2018
@Lestropie Lestropie added the build label Jul 21, 2018
@jdtournier

This comment has been minimized.

Copy link
Member Author

jdtournier commented Jul 29, 2018

included in #1393 - closing.

@jdtournier jdtournier closed this Jul 29, 2018
@jdtournier jdtournier deleted the remove_naked_except_statements branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.