New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting of number of threads from environment variable #866

Merged
merged 2 commits into from Dec 21, 2016

Conversation

Projects
None yet
2 participants
@jdtournier
Member

jdtournier commented Dec 21, 2016

This now also checks whether the MRTRIX_NTHREADS environment variable is
set, and if so will use that value instead of reading it from the config
file. However, the -nthreads option still take precedence.

Discussed on the forum:
http://community.mrtrix.org/t/control-multi-threading-on-a-cluster/632?u=jdtournier

allow setting of number of threads from environment variable
This now also checks whether the MRTRIX_NTHREADS environment variable is
set, and if so will use that value instead of reading it from the config
file. However, the -nthreads option still take precedence.

Discussed on the forum:
http://community.mrtrix.org/t/control-multi-threading-on-a-cluster/632?u=jdtournier

@jdtournier jdtournier self-assigned this Dec 21, 2016

@thijsdhollander

This comment has been minimized.

Show comment
Hide comment
@thijsdhollander

thijsdhollander Dec 21, 2016

Member

Sounds great, and should definitely help people setting up and managing MRtrix on a cluster. 👍

Member

thijsdhollander commented Dec 21, 2016

Sounds great, and should definitely help people setting up and managing MRtrix on a cluster. 👍

Fix setting number of threads from config file
Bug introduced in previous commit.
@jdtournier

This comment has been minimized.

Show comment
Hide comment
@jdtournier

jdtournier Dec 21, 2016

Member

Good thing I hadn't merged yet... All tested and seems to work fine now though - I'll merge.

Member

jdtournier commented Dec 21, 2016

Good thing I hadn't merged yet... All tested and seems to work fine now though - I'll merge.

@jdtournier jdtournier merged commit b5eeb17 into master Dec 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jdtournier jdtournier deleted the nthread_from_env branch Dec 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment