This repository has been archived by the owner on Feb 20, 2021. It is now read-only.
QFork fixes #236
Merged
QFork fixes #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #167 RejoinCOWPages used to call QueryWorkingSetEx to figure out which pages had been dirtied since the memory map was protected with PAGE_WRITECOPY. But dirty pages that had been swapped out to the system page file would be reported as not valid (VirtualAttributes.Valid == 0) and so we wouldn't restore them into the file map. QueryWorkingSetEx only gives information about pages that are in the working set at the time it is called. Pages can be forced into the working set using VirtualLock, but that seems like a potentially risky / expensive solution. I implemented a solution that uses VirtualQuery to find out which regions have changed protection from PAGE_WRITECOPY.
VirtualProtect is failing with ERROR_INVALID_PARAMETER. It's possible that this code path never worked because it is checking for Windows version 8.0. Windows 8's version number is 6.2, not 8.0. Conflicts: src/Win32_Interop/Win32_QFork.cpp
Correclty check for Windows 8 version (6.2), in case this code path gets re-enabled again. Note that Windows 10 has version number 10.0, so it would finally take the code path originally intended for Windows 8 and higher.
ghost
added
the
orangemocha
force-pushed
the
orangemocha-RejoinCowPages3
branch
from
bd9361b
to
05e0ac8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #167 and some other related changes.