Martin Schürrer MSch

Organizations

@sauspiel @PSPDFKit @PSPDFKit-labs
MSch commented on commit Quviq/eqc_ex@80a3002ef5
@MSch

You could do this in your mix.exs def project do [ ... preferred_cli_env: [ docs: :docs ], ] end

MSch commented on pull request hexpm/community#60
@MSch

Done

MSch commented on issue elixir-lang/elixir#3502
@MSch

@lexmag sure, go ahead!

MSch commented on issue elixir-lang/elixir#3502
@MSch

Should we have an explicit API or set it to nil? I haven't yet needed nil metadata values. IMO if I ever do I can just go straight to the pdict an…

@MSch
Logger metadata behavior
MSch deleted branch request_path at MSch/plug
MSch pushed to request_path at MSch/plug
@MSch
  • @MSch 4550f23
    request_uri -> request_path
MSch pushed to request_path at MSch/plug
@MSch
  • @MSch 78173d8
    request_uri -> request_path
MSch commented on pull request elixir-lang/plug#272
MSch opened pull request elixir-lang/plug#273
@MSch
request_uri -> request_path
1 commit with 27 additions and 27 deletions
MSch created branch request_path at MSch/plug
MSch commented on pull request elixir-lang/plug#272
@MSch

I'm +1 on request_path, my reasoning being that the RFC allows absolute URIs as well, so calling it request_uri makes sense for the RFC, but not fo…

MSch deleted branch full-path at MSch/plug
MSch commented on pull request elixir-lang/plug#272
@MSch

@josevalim force pushed

MSch pushed to full-path at MSch/plug
@MSch
  • @MSch f8eab2e
    Add Plug.Conn.request_uri
MSch commented on issue elixir-lang/plug#266
@MSch

@kevin1024 fyi Cowboy's request object is the second element in Conn's adapter tuple. {Plug.Adapters.Cowboy.Conn, req} = conn.adapter real_full_path =

MSch opened pull request elixir-lang/plug#272
@MSch
Switch to real full path
1 commit with 43 additions and 33 deletions
MSch created branch full-path at MSch/plug
MSch commented on issue elixir-lang/plug#266
@MSch

@josevalim what's wrong with full_path?

@MSch
  • @MSch 3846852
    Only compile on OS X where AVAHI exists per default.
MSch commented on issue elixir-lang/elixir#1191
@MSch

Right. :)

MSch commented on issue elixir-lang/elixir#1191
@MSch

Old issue but I just ran into something related... String.contains?("whatever", []) # false String.contains?("whatever", "") # true IMO [] should b…

MSch opened pull request ericmj/postgrex#87
@MSch
Send parse/describe/flush not parse/describe/sync.
1 commit with 18 additions and 9 deletions
MSch pushed to master at MSch/postgrex
@MSch
MSch deleted branch db-conn-id at PSPDFKit-labs/ecto
MSch closed pull request elixir-lang/ecto#774
@MSch
Log DB's connection ids
MSch commented on pull request elixir-lang/ecto#774
@MSch

I'm already handling it in my app, was just trying to get it upstream as well. However, after looking at the changes, they still look like too muc…