-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for bugs associating display IDs across cells #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… during variable assignment
…lay_id separately
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 80.03% 80.13% +0.09%
==========================================
Files 48 48
Lines 2399 2436 +37
==========================================
+ Hits 1920 1952 +32
- Misses 479 484 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During resample/assignment requests, results from duckdb queries would be assigned to
SUBSET_TO_DISPLAY_ID
. This is used whenhandle_format()
is called for any dataframe object to determine whether it's updating an existing display handler or if it's creating a new one.Changes:
SUBSET_TO_DISPLAY_ID
during a variable assignment requestSUBSET_TO_DISPLAY_ID
match before rendering/formatting a dataframe output, and falls back to using the kernel sidecar suppliedLAST_EXECUTED_CELL_ID
if no parent cell ID is foundformat()
calls to ensure we aren't trying to update display handlers across different cell executionsENABLE_DATALINK
/ENABLE_RENAME
/ENABLE_ASSIGNMENT
settings changes