Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traps #302

Closed
wants to merge 23 commits into from
Closed

Traps #302

wants to merge 23 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2018

Adds various traps for CTF. Namely,

  • Ghost stone

  • Ghost cobblestone

  • Ghost dirt

  • Spikes

  • Fake/Damage Cobblestone

Related to #35

Copy link
Contributor

@ClobberXD ClobberXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of indents using spaces. Please convert all of them to tab-indents. Will test in a couple of days.

mods/traps/depends.txt Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
@Thomas--S
Copy link
Member

Thomas--S commented Dec 13, 2018

👎 except for spikes because all other traps will probably be mainly used by griefers.

👍 for spikes.

Edit: Neutral on damage cobble

@ghost
Copy link
Author

ghost commented Dec 13, 2018

The damaging cobble cannot be used by griefers as it will only damage the opponent team

mods/traps/depends.txt Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Dec 14, 2018

I don't think I should add these traps to ctf_treasure as it will be much more easier for the griefers ( generally noobs) to get them. Currently having the traps being able to craft is the best option to reduce those griefers.

mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
mods/traps/init.lua Outdated Show resolved Hide resolved
@ClobberXD
Copy link
Contributor

This mod depends on ctf mod for retrieving the damaging-cobble's placer's team.

Please create a depends.txt for traps, and add ctf in it. Since the mod depends on ctf, please rename it to ctf_traps.

mods/traps/init.lua Outdated Show resolved Hide resolved
@ClobberXD
Copy link
Contributor

I performed my first round of testing, and here are my thoughts:

  • The fall-through nodes are very noticeable due to their yellow-green border. They could be subtler.
  • The spikes could be made a bit taller, to be more noticeable.

@ghost
Copy link
Author

ghost commented Dec 21, 2018

Yup

@ClobberXD
Copy link
Contributor

Textures look good to me. 👍

I suspect the damage cobble might be abused by tunnellers. On the other hand, that's alright, because the defending team should've protected their flag against tunnellers anyway. I feel this needs to be given more thought.

@ghost
Copy link
Author

ghost commented Dec 21, 2018

Well same can be said for the defending team because you can make a hole below and cover it all with dmg cobble. Also you can mine around it to get passed it.

@ClobberXD
Copy link
Contributor

Alright, makes sense (sorta). 👍 from me.

@ClobberXD
Copy link
Contributor

However it's worth gathering more opinions about the textures of the fake nodes before merging. I'm finding them well-balanced with respect to subtlety and ability to differentiate them in the dark as well (using default display_gamma)

mods/ctf_crafting/depends.txt Outdated Show resolved Hide resolved
@bewlay
Copy link

bewlay commented Jan 8, 2019

I can only make Spikes, the ghost and damage blocks seem to have misspelled ingredients.

@ghost
Copy link
Author

ghost commented Jan 8, 2019

@bewlay Thanks for that, did some silly mistakes and it should be fixed now

Copy link
Contributor

@ClobberXD ClobberXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@bewlay
Copy link

bewlay commented Jan 9, 2019

The fact that damage cobble looks always the same (regardless which team placed it) could be a problem. In some ways, that would be similar as if all blocks damaged you, as you don't want to dig a damage cobble block of which you don't know the origin (except maybe directly at the base, where you have time to heal anyway).

Good work otherwise, btw.

@ClobberXD
Copy link
Contributor

The fact that damage cobble looks always the same (regardless which team placed it) could be a problem.

I'd consider that a part of the challenge. Traps can be compared to a double-edged sword, which can damage the wielder as well.

@ghost
Copy link
Author

ghost commented Jan 9, 2019

The fact that damage cobble looks always the same (regardless which team placed it) could be a problem. In some ways, that would be similar as if all blocks damaged you, as you don't want to dig a damage cobble block of which you don't know the origin (except maybe directly at the base, where you have time to heal anyway).

If players would be able to differentiate then they would just mine around that cobble and there would be no point in having it.

@ghost
Copy link
Author

ghost commented Jan 12, 2019

I think the mod is complete but if anyone wants to test it and send any feedbacks then that would be helpful

@ClobberXD
Copy link
Contributor

Needs to be rebased to fix merge conflicts.

git checkout traps
git pull upstream master --rebase
# where upstream is the MT-CTF/capturetheflag base repo

@ghost
Copy link
Author

ghost commented Jan 13, 2019

Doesn't work :| . It can't find the 'MT-CTF/capturetheflag' git repository

@ClobberXD
Copy link
Contributor

Ok... can you paste the output of git remote -v?

@ghost
Copy link
Author

ghost commented Jan 13, 2019

@rubenwardy
Copy link
Member

I can rebase this before merging

@ghost
Copy link
Author

ghost commented Jan 13, 2019

Thanks

@rubenwardy
Copy link
Member

20daeeb

@rubenwardy rubenwardy closed this Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants