Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add River Valley by -sniper- #13

Merged
merged 6 commits into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@MinetestSam
Copy link
Contributor

commented Jan 24, 2019

River valley made by -sniper-
Related to #12

@MinetestSam MinetestSam changed the title River Valley by -sniper- Add River Valley by -sniper- Jan 24, 2019

@MinetestSam

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Good map with plenty of trees, mountains and water. 👍
screenshot_20190131_161837

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

The river water creates some issues with barriers and chests, as they only consider default:water_source and default:water_flowing to be water. I suggest converting the two types of river water into their corresponding normal water variants. i.e. Flowing river water -> flowing water, river water source -> water source.

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

@MinetestSam Would you be able to update the schem to the updated one posted in https://forum.minetest.net/viewtopic.php?p=342587#p342587?

MinetestSam added some commits Feb 3, 2019

@MinetestSam

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

Done, hmm GitHub crashed and it added a copied commit 🤔

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

That's fine, the second commit has no changes, anyway. Thanks!

@MinetestSam

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

screenshot_20190211_163153
screenshot_20190211_163148
screenshot_20190211_163134
The map does have several holes in the barrier.

@JostP

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

I think this happened because of river water (default:river_water_source) and grass (default:grass).

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Yes, indeed. Please fix this if possible, either manually or

  • Select middle barrier region.
  • //replace air ctf_map:ind_glass_red
  • //replace default:water_source ctf_map:ind_glass_red
@JostP

This comment has been minimized.

Copy link
Contributor

commented Feb 12, 2019

Fixed barrier:

river_valley.zip

zaslonska slika 2019-02-12 14-56-22

MinetestSam added some commits Feb 12, 2019

@MinetestSam

This comment has been minimized.

Copy link
Contributor Author

commented Feb 12, 2019

Barrier is fixed! Everything works good. Gets my approval 👍

@ClobberXD ClobberXD merged commit 08c5371 into MT-CTF:master Feb 12, 2019

@MinetestSam MinetestSam deleted the MinetestSam:river_valley branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.