Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monolithic Mountain by Camasia #16

Closed
wants to merge 8 commits into from

Conversation

@BrianGaucher
Copy link

commented Jan 27, 2019

I have not finished, but it nearly is.

Added my map
Not yet done.
@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Jan 27, 2019

I still need to do a little bit of terraforming to facilitate navigation. As well as add some ores. Then remove some plannification nodes (signs & torches). Then a thorough review.

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Jan 27, 2019

Maybe we should add the tag "Action/Change needed" since it's unfinished.

@ClobberXD ClobberXD added WIP and removed Review required labels Jan 28, 2019

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

Sorry, didn't notice that this map was unfinished.

Also, the "Action / change needed" label is for PRs in which changes/improvements have been requested by reviewers. Other incomplete PRs are labelled "WIP". :)

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Feb 7, 2019

I'm getting closer to finishing.

  • Done removing caves that leave the map.
  • Done adding an indestructible wall in the mountain between the flags (to prevent 2 minute rounds).
  • Done terraforming to facilitate climbing the mountain.
  • Done adding ores.
@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Feb 24, 2019

Alright, 99% done.
I'll test my schems now to verify everything works.

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Feb 25, 2019

Tested, seems good. I only tested the schem though, I don't know how to test it as a server match.

This map is no longer a WIP. Could you remove this tag. Also could you add "Review required".

@ClobberXD ClobberXD added Review required and removed WIP labels Feb 25, 2019

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

You can test it like so:

  • Download capturetheflag game into <minetest>/games
  • Copy-paste the schem and conf into <minetest>/games/capturetheflag/mods/ctf/ctf_map/maps
  • Create a new world for capturetheflag
  • Launch the game
  • Enter chat-commands /set_next monolithic (sets the next map to be the given one) and /ctf_next (skips to next map immediately) in the same order.
@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Feb 25, 2019

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Feb 27, 2019

I tested it out, I forgot to set the orientation during initial creation. Fixed that.
Only issue now is deciding what players begin with.
I think stone pick and stone sword would work well, but 3 torches would be nice. and maybe 5 ladders.

Added initial stuff
Also reorganized entries. And added my in-game name.
@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Feb 28, 2019

Schematic all good. Configuration complete. Tested as a server by myself. Initial stuff complete. Just needs to be tested and approved.

@JostP

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

I tested your map, BrianGaucher.
I have 2 suggestions to improve your map.

Believe me, players always makes tunnels if possible. I saw your indestructible wall inside the mountain, but i don't think it is enough big. I made screenshot (indestructible wall is inside digged blocks):

Zaslonska slika 2019-03-09 09-48-54

I think you should make indestructible wall a lot higher, deeper and wider so tunneling will be impossible.

And second, "r" of your map is 50, so your map is 4 times smaller than average ctf map (r = 110). So on your map is only 1/4 chests and spawned chests are too less IMO. I suggest to make custom chest zones and make number of chests to be placed in the zone between 30 and 50.

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Mar 10, 2019

@JostP Thanks for your review.

I'll be away all this week, but I'll implement your suggestion. I'll widen the wall. Question, should the wall span the entire height, or allow the very top section to be dug? (the top 20ish nodes).

Also only the top 40ish nodes are ore enriched, (coal is everywhere, steel also spawns below sea level) any comment on that.

Would the water around the map cause issues if it overflows?

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Mar 10, 2019

@ClobberXD Could you add "Action/ Change needed".

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

@BrianGaucher Let me repeat - Action / change needed is only for issues and PRs which are felt by the official reviewers to be incomplete. Other suggestions or work that you take upon yourself, classifies as WIP. Don't bother about these labels anyway, these are just for us reviewers to keep track of stuff, and don't indicate the reputation of the PR in any way.

@JostP

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

... or allow the very top section to be dug? (the top 20ish nodes).

I think, this is good idea. It is hard to climb up on the top of the mountain.

Would the water around the map cause issues if it overflows?

I think it doesn't.

@JostP

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

Maybe ti would be good, if you build a base/fortress on the top of mountain and on left and right side of the map. They are useful for defence and make game more interesting. Only suggestion.

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Mar 16, 2019

@ClobberXD Sorry, I'll stop worrying about labels. And just post a message when I feel it's complete.

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Mar 16, 2019

I won't build any towers on it, they aren't necessary for the map. But I'll fix the border in the mountain. I'll also fix the water just in case it would cause issues.

I'll also add the whole map as a chest area to enrich it slightly. I'll also make the top of the hill a third chest region (to encourage people to climb). And finally add a couple of chest in the cave.

@BrianGaucher

This comment has been minimized.

Copy link
Author

commented Mar 24, 2019

I have added the indestructible stone in the middle. Also, I used indestructible stone bricks so it's more obvious that it isn't normal bricks. I haven't added custom chest zones yet.

I am trying to figure out the best way to modify existing maps.

@ClobberXD

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@BrianGaucher What's left to address for this map to be merge-worthy? Are you still working on this?

@ClobberXD

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Closing due to lack of response from author. Can re-open upon progress.

@ClobberXD ClobberXD closed this Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.