Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page size validaton, api search form tests #1118

Merged
merged 8 commits into from Feb 9, 2018
Merged

Conversation

philtgun
Copy link
Contributor

@philtgun philtgun requested a review from ffont January 31, 2018 15:38
Copy link
Member

@ffont ffont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this patch @philtgun, all the code looks really good and comprehensive tests have been added. Maybe tests could be a bit more documented but this is minor issue as the tests are rather simple. Great work!

@ffont ffont merged commit 48ccc2c into master Feb 9, 2018
@ffont ffont deleted the page-size-validaton branch February 9, 2018 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants