Skip to content

Miscellaneous code cleanups#534

Merged
nschimme merged 8 commits into
MUME:masterfrom
nschimme:jahara-wip-2026-05-31a
Jun 1, 2026
Merged

Miscellaneous code cleanups#534
nschimme merged 8 commits into
MUME:masterfrom
nschimme:jahara-wip-2026-05-31a

Conversation

@nschimme

@nschimme nschimme commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @nschimme, your pull request is larger than the review limit of 150000 diff characters

@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.18380% with 253 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.39%. Comparing base (bcd8fca) to head (afe31b7).

Files with missing lines Patch % Lines
src/parser/AbstractParser-Commands.cpp 0.00% 19 Missing ⚠️
src/display/Connections.cpp 0.00% 16 Missing ⚠️
src/display/Characters.cpp 0.00% 14 Missing ⚠️
src/map/World.cpp 30.00% 14 Missing ⚠️
src/opengl/OpenGL.cpp 0.00% 13 Missing ⚠️
src/display/Infomarks.cpp 0.00% 11 Missing ⚠️
src/display/MapCanvasData.cpp 0.00% 11 Missing ⚠️
src/opengl/Font.cpp 0.00% 10 Missing ⚠️
src/display/mapcanvas.cpp 0.00% 9 Missing ⚠️
src/map/coordinate.cpp 30.76% 9 Missing ⚠️
... and 46 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   25.36%   25.39%   +0.02%     
==========================================
  Files         519      521       +2     
  Lines       43185    43178       -7     
  Branches     4706     4708       +2     
==========================================
+ Hits        10952    10963      +11     
+ Misses      32233    32215      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nschimme nschimme merged commit 7510a6b into MUME:master Jun 1, 2026
21 of 22 checks passed
@nschimme nschimme deleted the jahara-wip-2026-05-31a branch June 1, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant