Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poster generating capabilities #9

Merged
merged 1 commit into from
May 5, 2021

Conversation

pc-coholic
Copy link
Contributor

This PR adds a small helper class/function to generate CWA-posters.

Two layouts are included - the official portrait one as well as a landscape-version which has been inspired by the first one.

Since I'm not very good at graphics stuff, this might not be the best way to achieve the desired result - so feel free to discard this PR if it's not up to your standards :-)

(Since I ìsorted the imports of the files I touched with this PR, some sorting of the imports has occurred)

@pc-coholic
Copy link
Contributor Author

Using the posters/trademarks of the CWA might also relate to corona-warn-app/cwa-event-qr-code#8

Although since cwa-event-qr-code also ships the posters, and we're not advertising this library using the CWA-logo, I don't think this is really an issue here. But IANAL...

@MaZderMind
Copy link
Owner

Thank you very much! That's awesome!

I'd like to wait for the linked Issue to be settled before merging. I'd expect the CWA Crew to be quite responsive and quick.

@MaZderMind
Copy link
Owner

Regarding the Code I'd like to try to avoid the temp-file if possible. Don't know if it is though.

I would also like to see the poster Code in its own File. And while we're at it, i'd like to see "svgut" to be something recognizable. Bytes are cheap and IDEs do autocompletion quite well these days. Maybe "svg_utils"? Would you mind refactoring your PR like this?

@MaZderMind
Copy link
Owner

So the Discussion in corona-warn-app/cwa-event-qr-code#8 is resolved enough for me, but I still see the above mentioned problems with the code. If you don't mind I'll try to work them out.

@pc-coholic
Copy link
Contributor Author

Sure, feel free to do so!

Earliest I can have a look is probably around Wednesday - so whatever works best for you :)

@MaZderMind MaZderMind mentioned this pull request May 3, 2021
@MaZderMind MaZderMind merged commit 7d86ea9 into MaZderMind:main May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants