DBus API for the RecordPage. #399

Open
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@obiwankennedy

Those commits add DBus support for PageRecord. It allow to start and pause the recording from another software. In my case, teamspeak will start the video recording thank of ssr.

I just need to be able to start the recording by command line. So, I just implemented the PageRecord. I hope it will be an example, and you will be able to do it with all your pages.

You can call all public slots from PageRecord (I changed the visibility of some slots).

So, you can call them like this:
I start ssr, click ok until I reach the RecordPage, then I can send those commands:

dbus-send --type=method_call --session --dest=be.maartenbaert.ssr / local.PageRecord.OnRecordStartPause

dbus-send --type=method_call --session --dest=be.maartenbaert.ssr / local.PageRecord.OnCancel
dbus-send --type=method_call --session --dest=be.maartenbaert.ssr / local.PageRecord.OnSave
dbus-send --type=method_call --session --dest=be.maartenbaert.ssr / local.PageRecord.OnUpdateHotkeyFields
dbus-send --type=method_call --session --dest=be.maartenbaert.ssr / local.PageRecord.OnUpdateHotkey
dbus-send --type=method_call --session --dest=be.maartenbaert.ssr / local.PageRecord.OnUpdateSoundNotifications

Hoping, this modification will be included in the next version. If you have any questions about my work. I strongly recommend to put my work in a new branch. Then you will be able to test it a bit.

Regards
Renaud G.

@MaartenBaert

This comment has been minimized.

Show comment
Hide comment
@MaartenBaert

MaartenBaert Dec 4, 2015

Owner

This sounds useful, but it does add a dependency on dbus, which may be problematic for some platforms. I'm not sure, I will have to check. In any case this should be an optional feature that can be disabled with configure flags.

There are also a number of problems regarding reentrancy of some slots, the system tray patch created similar problems that were tricky to find. I will need to take a look at that too once I have some time. I will definitely look into this, but I don't have much time now.

Owner

MaartenBaert commented Dec 4, 2015

This sounds useful, but it does add a dependency on dbus, which may be problematic for some platforms. I'm not sure, I will have to check. In any case this should be an optional feature that can be disabled with configure flags.

There are also a number of problems regarding reentrancy of some slots, the system tray patch created similar problems that were tricky to find. I will need to take a look at that too once I have some time. I will definitely look into this, but I don't have much time now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment