Added support for callbacks and menus #14

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants

hildjj commented Jan 15, 2012

Tested callbacks on sound completion, then went on to support menus. Note: there are likely still some memory leaks due to the JavaScriptCore bridging fighting with ARC.

To use:
macgap.menu.getItem("File").submenu().addItem("Foo", "", function() { console.log("Foo!"); })

asgeo1 commented May 26, 2012

Awesome! I really needed a JS bridge for the menu.

This commit no longer works with master though - I was able to just take out the bits I needed. It would probably be a good idea to split this into some smaller commits too.

Awesome. Any chance of getting menu support in any time soon? That'd be hip.

micho commented Jun 3, 2012

I'd love to see this in.

Speaking of menus, how hard would it be to add a status bar menu (like dropbox's) with this? It'd be great to have the option, for "always-on" apps.

Bump :)

jeff-h referenced this pull request Mar 13, 2014

Merged

Add Callbacks and Menus #95

Owner

jeff-h commented Mar 30, 2014

@hildjj — I have just committed a (modified) version of your code. Thanks so much for your work!

jeff-h closed this Mar 30, 2014

hildjj commented Mar 30, 2014

Thanks. Sorry I never got around to replying to you. That code was from
long enough ago that I couldn't get excited about recreating the
environment. I'm glad you got it working!

On 3/30/14, 1:00 AM, "jeff-h" notifications@github.com wrote:

@hildjj https://github.com/hildjj — I have just committed a (modified)
version of your code. Thanks so much for your work!

Reply to this email directly or view it on GitHub
maccman#14 (comment).

Joe Hildebrand

Owner

jeff-h commented Mar 31, 2014

No worries—it was good to learn properly how it works. It's a great extension to MacGap's functionality too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment