Set player suck to full when not shooting #566

Merged
merged 1 commit into from Feb 28, 2012

5 participants

@danielduner

Turn on the player's coin-sucking ability instantaneously when not shooting, as discussed in #553.

Note that you still have to stop shooting for a while, as the coins will stop travelling towards you when you start shooting again.

@mkalam-alami
Collaborator

I'm ok to merge this.

@master-lincoln
Collaborator

me too

@Incanus-uk

Seems fine to me

@danielduner

No one has protested, so I'll just go ahead and merge it myself :)

@danielduner danielduner merged commit 32e2d60 into Maescool:master Feb 28, 2012
@Ankkah
Collaborator

Note that you still have to stop shooting for a while, as the coins will stop travelling towards you when you start shooting again.

isn't that what your changes did.

Now you can allways pickup instantly coins without stop shooting...
just by mouse clicking instead of "never-lift-the-finger-off-the-fire-button"

@mkalam-alami
Collaborator

@Ankkah Ouch, nice find

@danielduner

@Ankkah
Nope.
But it might look that way, because the coins pick up momentum really fast. We could make them accelerate slower, move slower or decelerate faster. That way you would have to have to wait longer.

@Ankkah
Collaborator

@danielduner

That code you changed was to slow down pick up and prevented instant pickup on mouse clicking.

@danielduner

@Ankkah
Or well.. sort of. But it was a bad solution as it affected suck range, rather than attraction speed or acceleration. Which meant poor visual feedback to the player.

@danielduner

@Ankkah
Feel free to post an issue about it. I'll create a pull request in 10 minutes or so, with my proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment