Fixed "Error in class 'SourceJava Sound': Channel null in method 'stop'" #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case, I guess the best way to see if there are downsides is to wait & see. Merging, thanks |
mkalam-alami
pushed a commit
that referenced
this pull request
Mar 2, 2012
Fixed "Error in class 'SourceJava Sound': Channel null in method 'stop'"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got rid of that annoying message:
It happened because 'channel' was null in
paulscode.sound.Source. I don't know why and neither do I know if this is a problem or not, but my solution seems to work. I don't usestop()anymore butcull(). According to the API it stops and flushes the sound source. It then needs to be reactivated before playback. By now I don't see any negative side effects.