[improvement] falling in holes #709

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Elosanda
Contributor
Elosanda commented Mar 3, 2012

if the player carries an item when falling, the item doesn't disappear but is also shown falling down

@danielduner
Contributor

@mkalam-alami
Should this go into master or develop? It is an improvement on existing functionality (almost a bug fix) but it does add new stuff. I'm still not sure about where to draw the line?

@Austin01
Collaborator
Austin01 commented Mar 3, 2012

I beleive it would be develop, and eventually the develop branch would go into master. I think the only time master is touched is when you merge a release branch. Though I'd wait for @mkalam-alami To confirm.

@danielduner
Contributor

Well, bug fixes should go into master. I'm just not sure if this is to be considered a bug fix or a feature.

@Elosanda
Contributor
Elosanda commented Mar 3, 2012

this has imho not a very high priority, though it improves user experience

@danielduner
Contributor

Okay. In that case, you can close this pull request and make a new one to Maescool:develop. Thank you :)

@Elosanda
Contributor
Elosanda commented Mar 3, 2012

ok, np

@Elosanda Elosanda closed this Mar 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment