Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Console! #778

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
Contributor

kylecbrodie commented Mar 5, 2012

A functioning console with a few predefined commands

@kylecbrodie kylecbrodie Console!
A functioning console with a few predefined commands
1c0596e
Contributor

Mebibyte commented Mar 5, 2012

+1

Although, I used /quit 1, and I got an error in Eclipse.

Exception in thread "Thread-3" java.lang.NullPointerException
at paulscode.sound.SoundSystem.setListenerPosition(SoundSystem.java:1282)
at com.mojang.mojam.sound.SoundPlayer.setListenerPosition(SoundPlayer.java:149)
at com.mojang.mojam.MojamComponent.render(MojamComponent.java:432)
at com.mojang.mojam.MojamComponent.run(MojamComponent.java:389)
at java.lang.Thread.run(Unknown Source)

Collaborator

mkalam-alami commented Mar 5, 2012

What about #703?

Collaborator

master-lincoln commented Mar 5, 2012

+1 I like the implementation...

Owner

Maescool commented Mar 5, 2012

@Mebibyte That's a soundsystem error, not rellevant with this code.
@kylebrodie please sync up, we else can't merge

Owner

Maescool commented Mar 5, 2012

anybody prefer this or #703?

Contributor

kylecbrodie commented Mar 5, 2012

I prefer this :P I believe that #703 lacked a good abstraction for commands. The commands should be self-contained and work on objects rather than commands being completed by objects.
@Mebibyte I knew about that but I didn't include it because the /exit was an example command and I just wanted to include the functioning console in this merge

@Maescool I think I am synced. Using GitHub for Mac and did a sync cycle

Owner

Maescool commented Mar 5, 2012

@kylebrodie you might be sync with your fork, but your fork is not in sync with this repo
github for mac doesn't support that sync (yet)
the only way is to merge via terminal..
git pull origin/develop
and see where possible merge errors are, fix the files, and resync to your fork

Contributor

Shephiroth commented Mar 5, 2012

Kyle, 703 didnt lack abstraction, use a diferent way of implementing it. Mine use an interface, yours use an abstract class. Both do their work.

The main difference is probably the /help command, you coded a way to list commands. Since this is a dev tool i never though that to be nedded.

Contributor

kylecbrodie commented Mar 5, 2012

I apologize. I made a second pull request so that the changes can be pulled as I cannot figure out how to sync my branch feature/console with origin/develop

@kylecbrodie kylecbrodie closed this Mar 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment