Thread#join has arity 1 #211

Closed
zenspider opened this Issue Jan 19, 2013 · 0 comments

Comments

Projects
None yet
2 participants
Contributor

zenspider commented Jan 19, 2013

Dunno why, but the following code sitting in Thread.rb:

primitive_nobridge 'join', '_join:'

followed immediately by a reimplementation of join in pure ruby. The former seems to confuse maglev, making it record that join has an arity of 1, when it doesn't anymore. That causes code like the following to break:

threads.each(&:join)

Because the to_proc creates an arity 0 call and then things blow up with an ArgumentError in a nasty undecipherable way.

timfel closed this in e123ee5 Jan 21, 2013

@timfel timfel added a commit that referenced this issue Jan 21, 2013

@timfel timfel Merge pull request #213 from MagLev/tim/fix-211
Fix #211
4ed9082

@bhenderson bhenderson pushed a commit to bhenderson/minitest that referenced this issue Jan 10, 2014

@zenspider zenspider Fixed: MagLev/maglev#211
[git-p4: depot-paths = "//src/minitest/dev/": change = 8136]
97aab55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment