Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis task exits with 0 even with failed tests #344

Closed
johnnyt opened this issue Mar 1, 2014 · 4 comments

Comments

Projects
None yet
3 participants
@johnnyt
Copy link
Member

commented Mar 1, 2014

As pointed out by @hqmq in #313 - the vmunit tests can fail but still exit with a 0. Example: https://travis-ci.org/MagLev/maglev/jobs/19664314#L1289

The travis rake task should exit with a non-zero value when a test fails.

johnnyt added a commit that referenced this issue Mar 1, 2014

Use current Rakefile
Created new issue #344 - Travis exiting with 0 even on failure
@timfel

This comment has been minimized.

Copy link
Member

commented Mar 1, 2014

Yes, and I've tried to address this in my PR for #313. The last few PRs that were merged did not run through all specs (and in fact the test for the non blocking TCPSocket failed on Travis). I think this very important to address so we don't accidentally merge regressions.

@mmmries

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2014

@timfel I agree that fixing the vmunit tests should be top priority before we add any more features so that we can have more confidence in accepting pull requests.

I'm guessing that the github338 test is failing because Travis won't let us bind to port 2000 (probably a good idea on their part). Any other ideas on how we can test that a TCPSocket can be made and it can read correctly?

@timfel timfel referenced this issue Mar 3, 2014

Merged

Fix #313 #342

@timfel

This comment has been minimized.

Copy link
Member

commented Mar 3, 2014

Closed via #342

@timfel timfel closed this Mar 3, 2014

@mmmries

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2014

@timfel 👏 👏 👏 Nice work! I'm really glad you figured out a way to get my read_nonblock test to run on travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.