Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

test and merge allen_magparse2 #402

Closed
AllenOtis opened this issue Jul 7, 2015 · 5 comments
Closed

test and merge allen_magparse2 #402

AllenOtis opened this issue Jul 7, 2015 · 5 comments

Comments

@AllenOtis
Copy link
Contributor

The following builds are available for download to go with the current state of
the allen_magparse2 branch. This branch ran vmunit tests ok on my private
server build on both Darwin and Linux .

I'm not sure where to edit in the download or install scripts to reference the latest build;
after that vmunit and spec tests need to be run.
The server version number in build 36816 is 3.1.0.2.2 .

http://seaside.gemtalksystems.com/maglev/GemStone-36816.Darwin-i386.tar.gz
http://seaside.gemtalksystems.com/maglev/GemStone-36816.Linux-x86_64.tar.gz

@johnnyt
Copy link
Member

johnnyt commented Jul 7, 2015

Awesome - thanks Allen!

We'll start testing this out (on Ubuntu and Darwin).

@johnnyt
Copy link
Member

johnnyt commented Jul 7, 2015

I'm getting this error on my Darwin machine (it works fine on Ubuntu):

/usr/bin/g++ -DFLG_FAST=1 -DNOT_JAVA_VM -D_GNU_SOURCE -D_REENTRANT -I/Users/johnnyt/.rbenv/versions/maglev-2.0.0-dev/gemstone/include -I/Users/johnnyt/.rbenv/versions/maglev-2.0.0-dev/gemstone/../../icu/source/common -I. -I/usr/local/Cellar/icu4c/54.1/include -Wunused-const-variable -Wchar-subscripts -Wcomment -Werror -Wmissing-braces -Wmultichar -Wno-aggregate-return -Wno-unused-function -Wparentheses -Wreturn-type -Wshadow -Wsign-compare -Wsign-promo -Wswitch -Wsystem-headers -Wtrigraphs -Wtrigraphs -Wunused-label -Wunused-value -Wunused-variable -Wwrite-strings  -fPIC -fcheck-new -fmessage-length=0 -fno-exceptions -fno-strict-aliasing -O3 -g -Wuninitialized -m64 -pipe -pthread -x c++   -c -o rubygrammar.o rubygrammar.c
rubygrammar.c:4:19: error: unused variable 'yysccsid' [-Werror,-Wunused-const-variable]
static const char yysccsid[] = "@(#)yaccpar     1.9 (Berkeley) 02/21/93";
                  ^
1 error generated.
make: *** [rubygrammar.o] Error 1

Any ideas?

@AllenOtis
Copy link
Contributor Author

I think we want this deletion so we can reenable -Werror

diff --git a/src/kernel/parser/byacc/skeleton.c
b/src/kernel/parser/byacc/skeleton.c
index 1751cca..91875fc 100644
--- a/src/kernel/parser/byacc/skeleton.c
+++ b/src/kernel/parser/byacc/skeleton.c
@@ -16,10 +16,6 @@

const char *banner[] =
{

  • "#ifndef lint",
  • "static const char yysccsid[] = "@(#)yaccpar 1.9 (Berkeley)
    02/21/93";",
  • "#endif",
  • "",
    "#define YYBYACC 1",

On Tue, Jul 7, 2015 at 3:00 PM, JohnnyT notifications@github.com wrote:

I'm getting this error on my machine:

/usr/bin/g++ -DFLG_FAST=1 -DNOT_JAVA_VM -D_GNU_SOURCE -D_REENTRANT -I/Users/johnnyt/.rbenv/versions/maglev-2.0.0-dev/gemstone/include -I/Users/johnnyt/.rbenv/versions/maglev-2.0.0-dev/gemstone/../../icu/source/common -I. -I/usr/local/Cellar/icu4c/54.1/include -Wunused-const-variable -Wchar-subscripts -Wcomment -Werror -Wmissing-braces -Wmultichar -Wno-aggregate-return -Wno-unused-function -Wparentheses -Wreturn-type -Wshadow -Wsign-compare -Wsign-promo -Wswitch -Wsystem-headers -Wtrigraphs -Wtrigraphs -Wunused-label -Wunused-value -Wunused-variable -Wwrite-strings -fPIC -fcheck-new -fmessage-length=0 -fno-exceptions -fno-strict-aliasing -O3 -g -Wuninitialized -m64 -pipe -pthread -x c++ -c -o rubygrammar.o rubygrammar.c
rubygrammar.c:4:19: error: unused variable 'yysccsid' [-Werror,-Wunused-const-variable]
static const char yysccsid[] = "@(#)yaccpar 1.9 (Berkeley) 02/21/93";
^
1 error generated.
make: *** [rubygrammar.o] Error 1

Any ideas?


Reply to this email directly or view it on GitHub
#402 (comment).

@johnnyt
Copy link
Member

johnnyt commented Jul 8, 2015

Done - that fixed it

@johnnyt
Copy link
Member

johnnyt commented Jul 9, 2015

Closed by #405

@johnnyt johnnyt closed this as completed Jul 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants