New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for IO#read_nonblock #339

Merged
merged 1 commit into from Mar 1, 2014

Conversation

Projects
None yet
3 participants
@mmmries
Copy link
Contributor

mmmries commented Mar 1, 2014

Addresses #338

@johnnyt

This comment has been minimized.

Copy link
Member

johnnyt commented Mar 1, 2014

👍
Looks good - thanks @hqmq

johnnyt added a commit that referenced this pull request Mar 1, 2014

Merge pull request #339 from hqmq/michael/github338
fix for IO#read_nonblock

@johnnyt johnnyt merged commit 082bb9b into MagLev:master Mar 1, 2014

1 check passed

default The Travis CI build passed
Details
@timfel

This comment has been minimized.

Copy link
Member

timfel commented Mar 1, 2014

@hqmq does this mean Puma works properly now? If so, any timing results?

@mmmries

This comment has been minimized.

Copy link
Contributor Author

mmmries commented Mar 1, 2014

Yes Puma is working. I posted my timing results + some caveats here:
http://devblog.riesd.com/blog/2014/02/28/puma-mostly-running-on-maglev

On Sat, Mar 1, 2014 at 2:02 PM, Tim Felgentreff notifications@github.comwrote:

@hqmq https://github.com/hqmq does this mean Puma works properly now?
If so, any timing results?

Reply to this email directly or view it on GitHubhttps://github.com//pull/339#issuecomment-36436513
.

timfel added a commit that referenced this pull request Mar 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment