Skip to content
This repository has been archived by the owner on Mar 26, 2023. It is now read-only.

Uses environment variable for stonehost if available #436

Merged
merged 2 commits into from
Sep 26, 2015

Conversation

johnnyt
Copy link
Member

@johnnyt johnnyt commented Aug 18, 2015

Closes #435

@AllenOtis or @dalehenrich - do you see any issues with this addition (using the value of $STONEHOST by default)?

@AllenOtis
Copy link
Contributor

The base server doesn't use STONEHOST .
I general I would prefer command line args where feasible.
Otherwise I would suggest environment variables should be preceeded with
MAGLEV
to try to avoid collision with other environment vars not related to Maglev.

On Tue, Aug 18, 2015 at 1:40 PM, JohnnyT notifications@github.com wrote:

Closes #435 #435

@AllenOtis https://github.com/AllenOtis or @dalehenrich
https://github.com/dalehenrich - do you see any issues with this

addition (using the value of $STONEHOST by default)?

You can view, comment on, or merge this pull request online at:

#436
Commit Summary

  • Uses STONEHOST env var if available

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#436.

@johnnyt
Copy link
Member Author

johnnyt commented Aug 18, 2015

Allrighty - I changed it to use MAGLEV_STONEHOST instead of STONEHOST

@johnnyt johnnyt changed the title Uses STONEHOST env var if available Uses environment variable for stonehost if available Aug 18, 2015
johnnyt added a commit that referenced this pull request Sep 26, 2015
Uses environment variable for stonehost if available
@johnnyt johnnyt merged commit 411bba5 into master Sep 26, 2015
@johnnyt johnnyt deleted the feature/stonehost branch September 26, 2015 19:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants