Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native macOS colors for themes #176

Merged
merged 12 commits into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@MattIPv4
Copy link
Member

commented Jun 20, 2019

This pull request intends to make the following changes:

Themes

  • Generates dark & light theme variables from macOS system properties during the build process on a macOS device
  • Uses native colors for all parts of the light and dark mode themes in the GUI
  • Splits all old theme styling into correct component files, theme files are just variables now
  • Resolves ongoing issue with capture referring to the wrong tooltip component path
  • Sets minimum sizes for main GUI components and the whole electron browser window

Other

  • Declares the node version in .nvmrc as I'm using nvm locally
  • Fixes invalid HTML in the uploader config, resolving the issue with the test & set default buttons not wrapping

@MattIPv4 MattIPv4 requested a review from JakeMakesStuff Jun 20, 2019

@MattIPv4 MattIPv4 self-assigned this Jun 20, 2019

@MattIPv4

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

Codacy error is a known bug with CSSLint: CSSLint/csslint#603 (comment)

@JakeMakesStuff JakeMakesStuff merged commit af291fd into develop Jun 20, 2019

2 of 3 checks passed

Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
WIP Ready for review
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@JakeMakesStuff JakeMakesStuff deleted the MattIPv4/themes branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.